Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1342153003: ipc: Remove basictypes.h includes. (Closed)

Created:
5 years, 3 months ago by tfarina
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam, viettrungluu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Remove basictypes.h includes. * macros.h replaces it for the usage of DISALLOW_X macros. BUG=138542 TEST=ipc_unittests R=tsepez@chromium.org Committed: https://crrev.com/4da8275d275e6c7cc69f2968fc76a49cab888721 Cr-Commit-Position: refs/heads/master@{#349081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M ipc/ipc_channel_posix_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_attachment_set.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_attachment_set_posix_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_perftest_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_platform_file.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_security_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message.h View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ipc/ipc_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_test_sink.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
5 years, 3 months ago (2015-09-15 20:08:48 UTC) #1
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-15 20:12:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342153003/1
5 years, 3 months ago (2015-09-16 03:24:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 09:56:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4da8275d275e6c7cc69f2968fc76a49cab888721 Cr-Commit-Position: refs/heads/master@{#349081}
5 years, 3 months ago (2015-09-16 09:57:18 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:53:51 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4da8275d275e6c7cc69f2968fc76a49cab888721
Cr-Commit-Position: refs/heads/master@{#349081}

Powered by Google App Engine
This is Rietveld 408576698