Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: Source/core/workers/WorkerObjectProxy.h

Issue 134213006: Update worker classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/workers/WorkerNavigator.h ('k') | Source/core/workers/WorkerScriptLoader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 29 matching lines...) Expand all
40 40
41 class ExecutionContext; 41 class ExecutionContext;
42 class WorkerMessagingProxy; 42 class WorkerMessagingProxy;
43 43
44 // A proxy to talk to the worker object. This object is created on the 44 // A proxy to talk to the worker object. This object is created on the
45 // worker object thread (i.e. usually the main thread), passed on to 45 // worker object thread (i.e. usually the main thread), passed on to
46 // the worker thread, and used just to proxy messages to the 46 // the worker thread, and used just to proxy messages to the
47 // WorkerMessagingProxy on the worker object thread. 47 // WorkerMessagingProxy on the worker object thread.
48 // 48 //
49 // Used only by Dedicated Worker. 49 // Used only by Dedicated Worker.
50 class WorkerObjectProxy : public WorkerReportingProxy { 50 class WorkerObjectProxy FINAL : public WorkerReportingProxy {
51 public: 51 public:
52 static PassOwnPtr<WorkerObjectProxy> create(ExecutionContext*, WorkerMes sagingProxy*); 52 static PassOwnPtr<WorkerObjectProxy> create(ExecutionContext*, WorkerMes sagingProxy*);
53 ~WorkerObjectProxy() { } 53 virtual ~WorkerObjectProxy() { }
eseidel 2014/01/11 02:35:38 Bleh. inline destructors. :(
54 54
55 void postMessageToWorkerObject(PassRefPtr<SerializedScriptValue>, PassOw nPtr<MessagePortChannelArray>); 55 void postMessageToWorkerObject(PassRefPtr<SerializedScriptValue>, PassOw nPtr<MessagePortChannelArray>);
56 56
57 void confirmMessageFromWorkerObject(bool hasPendingActivity); 57 void confirmMessageFromWorkerObject(bool hasPendingActivity);
58 void reportPendingActivity(bool hasPendingActivity); 58 void reportPendingActivity(bool hasPendingActivity);
59 59
60 // WorkerReportingProxy overrides. 60 // WorkerReportingProxy overrides.
61 virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL) OVERRIDE; 61 virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL) OVERRIDE;
62 virtual void reportConsoleMessage(MessageSource, MessageLevel, const Str ing& message, int lineNumber, const String& sourceURL) OVERRIDE; 62 virtual void reportConsoleMessage(MessageSource, MessageLevel, const Str ing& message, int lineNumber, const String& sourceURL) OVERRIDE;
63 virtual void postMessageToPageInspector(const String&) OVERRIDE; 63 virtual void postMessageToPageInspector(const String&) OVERRIDE;
64 virtual void updateInspectorStateCookie(const String&) OVERRIDE; 64 virtual void updateInspectorStateCookie(const String&) OVERRIDE;
65 virtual void workerGlobalScopeStarted() OVERRIDE { } 65 virtual void workerGlobalScopeStarted() OVERRIDE { }
66 virtual void workerGlobalScopeClosed() OVERRIDE; 66 virtual void workerGlobalScopeClosed() OVERRIDE;
67 virtual void workerGlobalScopeDestroyed() OVERRIDE; 67 virtual void workerGlobalScopeDestroyed() OVERRIDE;
68 68
69 private: 69 private:
70 WorkerObjectProxy(ExecutionContext*, WorkerMessagingProxy*); 70 WorkerObjectProxy(ExecutionContext*, WorkerMessagingProxy*);
71 71
72 // These objects always outlive this proxy. 72 // These objects always outlive this proxy.
73 ExecutionContext* m_executionContext; 73 ExecutionContext* m_executionContext;
74 WorkerMessagingProxy* m_messagingProxy; 74 WorkerMessagingProxy* m_messagingProxy;
75 }; 75 };
76 76
77 } // namespace WebCore 77 } // namespace WebCore
78 78
79 #endif // WorkerObjectProxy_h 79 #endif // WorkerObjectProxy_h
OLDNEW
« no previous file with comments | « Source/core/workers/WorkerNavigator.h ('k') | Source/core/workers/WorkerScriptLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698