Issue 134213006: Update worker classes to use OVERRIDE / FINAL when needed

Issue 134213006: Update worker classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
alecflett, eseidel

CC:
blink-reviews, kinuko+watch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Update worker classes to use OVERRIDE / FINAL when needed Update worker classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=eseidel, alecflett BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164925

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -38 lines)			Patch
M	Source/core/workers/AbstractWorker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/DedicatedWorkerGlobalScope.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/DedicatedWorkerThread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/SharedWorker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/SharedWorkerGlobalScope.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/Worker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/WorkerConsole.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/workers/WorkerEventQueue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/WorkerGlobalScope.h	View	5 chunks	+18 lines, -18 lines	0 comments	Download
M	Source/core/workers/WorkerMessagingProxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/WorkerNavigator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/WorkerObjectProxy.h	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	Source/core/workers/WorkerScriptLoader.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/serviceworkers/NavigatorServiceWorker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/serviceworkers/ServiceWorkerGlobalScope.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/serviceworkers/ServiceWorkerThread.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/134213006/diff/1/Source/core/workers/WorkerObjectProxy.h File Source/core/workers/WorkerObjectProxy.h (right): https://codereview.chromium.org/134213006/diff/1/Source/core/workers/WorkerObjectProxy.h#newcode53 Source/core/workers/WorkerObjectProxy.h:53: virtual ~WorkerObjectProxy() { } Bleh. inline destructors. :(

6 years, 11 months ago (2014-01-11 02:35:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134213006/1

6 years, 11 months ago (2014-01-11 02:36:15 UTC) #3

Message was sent while issue was closed.

Change committed as 164925

Expand Messages | Collapse Messages