Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 134213003: Revert of Implement DriveAppRegistry::UninstallApp() and GetAppList(). (Closed)

Created:
6 years, 11 months ago by Marijn Kruisselbrink
Modified:
6 years, 11 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/133123004/ Reason for revert: Broke compilation on a number of bots on the main waterfall TBR=hashimoto@chromium.org,kinaba@chromium.org NOTREECHECKS=true NOTRY=true BUG=324166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -135 lines) Patch
M chrome/browser/drive/drive_app_registry.h View 3 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/drive/drive_app_registry.cc View 3 chunks +0 lines, -51 lines 0 comments Download
M chrome/browser/drive/drive_app_registry_unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 2 chunks +1 line, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marijn Kruisselbrink
Created Revert of Implement DriveAppRegistry::UninstallApp() and GetAppList().
6 years, 11 months ago (2014-01-10 17:21:55 UTC) #1
Marijn Kruisselbrink
One example of such a compile error: FAILED: c++ -MMD -MF obj/chrome/browser/drive/browser.drive_app_registry.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD ...
6 years, 11 months ago (2014-01-10 17:22:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/134213003/1
6 years, 11 months ago (2014-01-10 17:23:39 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 17:25:09 UTC) #4
Message was sent while issue was closed.
Change committed as 244189

Powered by Google App Engine
This is Rietveld 408576698