Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 1342043002: Remove useless string IDS_WEBRTC_LOGS_LOG_LOCAL_FILE_FORMAT. (Closed)

Created:
5 years, 3 months ago by newt (away)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove useless string IDS_WEBRTC_LOGS_LOG_LOCAL_FILE_FORMAT. This string contains nothing but a placeholder; it doesn't need to exist. Plus, it's not translated (even though it's not marked translateable="false") so it messes with translation stats. BUG=518020 Committed: https://crrev.com/6d361f6a0e471694bd2ab31a0793390aaf62e7c8 Cr-Commit-Position: refs/heads/master@{#348965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/media/webrtc_logs.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/media/webrtc_logs_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
newt (away)
PTAL
5 years, 3 months ago (2015-09-15 01:33:20 UTC) #2
Henrik Grunell
lgtm
5 years, 3 months ago (2015-09-15 07:32:19 UTC) #3
Henrik Grunell
On 2015/09/15 07:32:19, Henrik Grunell wrote: > lgtm Thanks for doing this!
5 years, 3 months ago (2015-09-15 07:32:39 UTC) #4
newt (away)
+dbeam as browser/resources and webui OWNER
5 years, 3 months ago (2015-09-15 16:50:10 UTC) #8
Dan Beam
lgtm w00t
5 years, 3 months ago (2015-09-15 17:50:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342043002/1
5 years, 3 months ago (2015-09-15 18:57:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 19:51:07 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d361f6a0e471694bd2ab31a0793390aaf62e7c8 Cr-Commit-Position: refs/heads/master@{#348965}
5 years, 3 months ago (2015-09-15 19:51:41 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:48:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d361f6a0e471694bd2ab31a0793390aaf62e7c8
Cr-Commit-Position: refs/heads/master@{#348965}

Powered by Google App Engine
This is Rietveld 408576698