Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3865)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 1342033002: Add tooltips to cr-policy-indicator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_521791_settings_policy_1
Patch Set: Feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 1e6e43d359dddb9e7cd57dd2bbec760bb321d6ac..6577585f0a18a0192dfb97df8a306c9020870ceb 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -23,6 +23,27 @@ namespace {
// the following name. These names must be kept in sync.
const char kLocalizedStringsFile[] = "strings.js";
+void AddCommonStrings(content::WebUIDataSource* html_source) {
+ html_source->AddLocalizedString("basicPageTitle", IDS_SETTINGS_BASIC);
+ html_source->AddLocalizedString("advancedPageTitle", IDS_SETTINGS_ADVANCED);
+ html_source->AddLocalizedString("addLabel", IDS_ADD);
+#if defined(OS_CHROMEOS)
+ html_source->AddLocalizedString("controlledSettingShared",
+ IDS_OPTIONS_CONTROLLED_SETTING_SHARED);
+ html_source->AddLocalizedString("controlledSettingOwner",
+ IDS_OPTIONS_CONTROLLED_SETTING_OWNER);
+#endif
+ html_source->AddLocalizedString("controlledSettingPolicy",
+ IDS_OPTIONS_CONTROLLED_SETTING_POLICY);
+ html_source->AddLocalizedString("controlledSettingRecommendedMatches",
+ IDS_OPTIONS_CONTROLLED_SETTING_RECOMMENDED);
+ html_source->AddLocalizedString(
+ "controlledSettingRecommendedDiffers",
+ IDS_OPTIONS_CONTROLLED_SETTING_HAS_RECOMMENDATION);
+ html_source->AddLocalizedString("controlledSettingExtension",
+ IDS_SETTINGS_CONTROLLED_SETTING_EXTENSION);
+}
+
void AddA11yStrings(content::WebUIDataSource* html_source) {
html_source->AddLocalizedString(
"a11yPageTitle", IDS_SETTINGS_ACCESSIBILITY);
@@ -160,10 +181,6 @@ void AddClearBrowsingDataStrings(content::WebUIDataSource* html_source) {
IDS_SETTINGS_CLEAR_DATA_EVERYTHING);
}
-void AddCommonStrings(content::WebUIDataSource* html_source) {
- html_source->AddLocalizedString("addLabel", IDS_ADD);
-}
-
void AddDownloadsStrings(content::WebUIDataSource* html_source) {
html_source->AddLocalizedString(
"downloadsPageTitle", IDS_SETTINGS_DOWNLOADS);
@@ -458,16 +475,12 @@ void AddUsersStrings(content::WebUIDataSource* html_source) {
namespace settings {
void AddLocalizedStrings(content::WebUIDataSource* html_source) {
- html_source->AddLocalizedString("basicPageTitle",
- IDS_SETTINGS_BASIC);
- html_source->AddLocalizedString("advancedPageTitle",
- IDS_SETTINGS_ADVANCED);
+ AddCommonStrings(html_source);
AddA11yStrings(html_source);
AddAppearanceStrings(html_source);
AddCertificateManagerStrings(html_source);
AddClearBrowsingDataStrings(html_source);
- AddCommonStrings(html_source);
AddDownloadsStrings(html_source);
AddDateTimeStrings(html_source);
#if defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/resources/settings/checkbox/checkbox.css ('k') | chrome/common/extensions/api/settings_private.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698