Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 134203002: remove SK_SUPPORT_LEGACY_COLORTYPE as all callsites have been updated (Closed)

Created:
6 years, 11 months ago by reed1
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

remove SK_SUPPORT_LEGACY_COLORTYPE as all callsites have been updated BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M skia/skia_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
6 years, 11 months ago (2014-01-10 16:24:37 UTC) #1
robertphillips
lgtm as long as the bots pass
6 years, 11 months ago (2014-01-10 16:27:43 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-10 16:56:26 UTC) #3
reed1
6 years, 11 months ago (2014-01-10 17:02:24 UTC) #4
f(malita)
lgtm
6 years, 11 months ago (2014-01-10 17:03:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/134203002/1
6 years, 11 months ago (2014-01-10 17:09:56 UTC) #6
reed1
do you guys understand why those bots went red?
6 years, 11 months ago (2014-01-10 19:21:10 UTC) #7
f(malita)
On 2014/01/10 19:21:10, reed1 wrote: > do you guys understand why those bots went red? ...
6 years, 11 months ago (2014-01-10 19:30:12 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 22:01:47 UTC) #9
Message was sent while issue was closed.
Change committed as 244255

Powered by Google App Engine
This is Rietveld 408576698