Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1342023002: Skip CRWGenericContentView layout if the bounds size hasn't changed. (Closed)

Created:
5 years, 3 months ago by kkhorimoto
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip CRWGenericContentView layout if the bounds size hasn't changed. This fixes the bug where overscroll actions that update the scroll view content inset trigger a relayout of the contained view. BUG=none Committed: https://crrev.com/5e0bda2bd8c278ecd890720a0600c6ecbcd4c35d Cr-Commit-Position: refs/heads/master@{#348795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M ios/web/web_state/ui/crw_generic_content_view.mm View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
kkhorimoto
This fixes a bug in SadTab layout.
5 years, 3 months ago (2015-09-15 00:37:19 UTC) #2
Eugene But (OOO till 7-30)
lgtm
5 years, 3 months ago (2015-09-15 00:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342023002/1
5 years, 3 months ago (2015-09-15 00:50:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 01:00:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5e0bda2bd8c278ecd890720a0600c6ecbcd4c35d Cr-Commit-Position: refs/heads/master@{#348795}
5 years, 3 months ago (2015-09-15 01:01:05 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:40:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e0bda2bd8c278ecd890720a0600c6ecbcd4c35d
Cr-Commit-Position: refs/heads/master@{#348795}

Powered by Google App Engine
This is Rietveld 408576698