Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1342013003: Vector ICs: Hook up vectors in platform builtins to their SharedFunctionInfos. (Closed)

Created:
5 years, 3 months ago by mvstanton
Modified:
5 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector ICs: Hook up vectors in platform builtins to their SharedFunctionInfos. BUG=v8:4423 LOG=N Committed: https://crrev.com/905e008c52ba06120f4a523aab00a53bc50830f1 Cr-Commit-Position: refs/heads/master@{#30758}

Patch Set 1 #

Patch Set 2 : Most ports. #

Patch Set 3 : Test and remaining ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -110 lines) Patch
M src/arm/builtins-arm.cc View 1 2 7 chunks +26 lines, -19 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 6 chunks +36 lines, -20 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 7 chunks +24 lines, -15 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 7 chunks +26 lines, -19 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 7 chunks +26 lines, -19 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 7 chunks +25 lines, -15 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 chunks +44 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mvstanton
Hi Ulan, Here is the CL we've been discussing...
5 years, 3 months ago (2015-09-15 14:01:22 UTC) #2
ulan
LGTM, thank you for fixing! As we discussed, a regression test (if possible) would be ...
5 years, 3 months ago (2015-09-15 16:17:38 UTC) #3
mvstanton
Hi Ulan, Thanks for the review! Have a quick look at the test, it shows ...
5 years, 3 months ago (2015-09-16 04:59:48 UTC) #4
ulan
The test lgtm. Thanks!
5 years, 3 months ago (2015-09-16 08:06:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342013003/40001
5 years, 3 months ago (2015-09-16 09:31:27 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-16 10:08:57 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 10:09:11 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/905e008c52ba06120f4a523aab00a53bc50830f1
Cr-Commit-Position: refs/heads/master@{#30758}

Powered by Google App Engine
This is Rietveld 408576698