Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1342003002: Add -j flag to git cl comments to get JSON summary of CL comments (Closed)

Created:
5 years, 3 months ago by smut
Modified:
5 years, 3 months ago
Reviewers:
Vadim Sh., M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add -j flag to git cl comments to get JSON summary of CL comments BUG=529169 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296691

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M git_cl.py View 1 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
smut
5 years, 3 months ago (2015-09-14 23:47:17 UTC) #4
Vadim Sh.
lgtm, but I'm not an OWNER https://codereview.chromium.org/1342003002/diff/40001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1342003002/diff/40001/git_cl.py#newcode1805 git_cl.py:1805: 'not lgtm': False, ...
5 years, 3 months ago (2015-09-15 03:15:34 UTC) #5
Vadim Sh.
On 2015/09/15 03:15:34, Vadim Sh. wrote: > lgtm, but I'm not an OWNER > > ...
5 years, 3 months ago (2015-09-15 03:15:48 UTC) #6
smut
https://codereview.chromium.org/1342003002/diff/40001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1342003002/diff/40001/git_cl.py#newcode1805 git_cl.py:1805: 'not lgtm': False, On 2015/09/15 03:15:34, Vadim Sh. wrote: ...
5 years, 3 months ago (2015-09-15 16:18:41 UTC) #8
M-A Ruel
lgtm
5 years, 3 months ago (2015-09-15 16:31:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342003002/60001
5 years, 3 months ago (2015-09-15 16:32:48 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 16:34:46 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296691

Powered by Google App Engine
This is Rietveld 408576698