Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1341993002: Make sure ar_sample_app is actually built in the GN build. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure ar_sample_app is actually built in the GN build. R=garykac@chromium.org BUG=471916 Committed: https://crrev.com/03377b810fb09f818d1843f1cb7be98c1ee5866d Cr-Commit-Position: refs/heads/master@{#348788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-14 23:30:12 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341993002/1
5 years, 3 months ago (2015-09-14 23:31:07 UTC) #3
garykac
lgtm
5 years, 3 months ago (2015-09-14 23:52:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 00:10:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341993002/1
5 years, 3 months ago (2015-09-15 00:22:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 00:30:30 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/03377b810fb09f818d1843f1cb7be98c1ee5866d Cr-Commit-Position: refs/heads/master@{#348788}
5 years, 3 months ago (2015-09-15 00:31:15 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:40:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/03377b810fb09f818d1843f1cb7be98c1ee5866d
Cr-Commit-Position: refs/heads/master@{#348788}

Powered by Google App Engine
This is Rietveld 408576698