Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1341943002: gn-mode: Clear indent-tabs-mode (Closed)

Created:
5 years, 3 months ago by Roland McGrath
Modified:
5 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn-mode: Clear indent-tabs-mode GN does not allow tabs, so the mode should always set indent-tabs-mode to nil (off), regardless of the user's global setting. R=erg@chromium.org BUG= Committed: https://crrev.com/dfba3a3b99597d2c7f9ce0f3c7021f03a6afc300 Cr-Commit-Position: refs/heads/master@{#348753}

Patch Set 1 #

Patch Set 2 : bogon #

Patch Set 3 : bogon 2 #

Patch Set 4 : bogon 3 #

Patch Set 5 : rietveld sucks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/misc/emacs/gn-mode.el View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Roland McGrath
5 years, 3 months ago (2015-09-14 22:37:30 UTC) #1
Elliot Glaysher
"Bad content. Try to upload again." (That said, if all you are doing is a ...
5 years, 3 months ago (2015-09-14 22:39:16 UTC) #2
Roland McGrath
On 2015/09/14 22:39:16, Elliot Glaysher wrote: > "Bad content. Try to upload again." > > ...
5 years, 3 months ago (2015-09-14 22:41:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341943002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341943002/80001
5 years, 3 months ago (2015-09-14 22:49:46 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-14 23:06:13 UTC) #7
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/dfba3a3b99597d2c7f9ce0f3c7021f03a6afc300 Cr-Commit-Position: refs/heads/master@{#348753}
5 years, 3 months ago (2015-09-14 23:06:46 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:38:33 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/dfba3a3b99597d2c7f9ce0f3c7021f03a6afc300
Cr-Commit-Position: refs/heads/master@{#348753}

Powered by Google App Engine
This is Rietveld 408576698