scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json - Issue 134193014: Make recipes use the new way of enabling goma.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json

Issue 134193014: Make recipes use the new way of enabling goma. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium/config.py ('K') | « scripts/slave/recipes/chromium_trybot.expected/mac_release_git.json ('k') | scripts/slave/recipes/chromium_trybot.expected/success_fail_base_unittests.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json

===================================================================

--- scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json (revision 248765)

+++ scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json (working copy)

@@ -101,7 +101,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 target_arch=x64",

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir=[BUILD]/goma target_arch=x64 use_goma=1",

"GYP_GENERATORS": "ninja"

"name": "gclient runhooks"

@@ -121,6 +121,8 @@

"ninja",

"--compiler",

"goma",

+ "--goma-dir",

+ "[BUILD]/goma",

"--",

"base_unittests",

"cacheinvalidation_unittests",

@@ -1071,7 +1073,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 target_arch=x64",

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir=[BUILD]/goma target_arch=x64 use_goma=1",

"GYP_GENERATORS": "ninja"

"name": "gclient runhooks (2)",

@@ -1095,6 +1097,8 @@

"ninja",

"--compiler",

"goma",

+ "--goma-dir",

+ "[BUILD]/goma",

"--",

"media_unittests"

@@ -1115,6 +1119,8 @@

"ninja",

"--compiler",

"goma",

+ "--goma-dir",

+ "[BUILD]/goma",

"--clobber",

"--",

"media_unittests"