components/ssl_errors/BUILD.gn - Issue 1341923002: Create a component for SSL error handling

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ssl_errors/BUILD.gn

Issue 1341923002: Create a component for SSL error handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaning up for review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("about_handler") {	5 # GYP version: components/ssl_errors.gyp

	6 static_library("ssl_errors") {
	blundell 2015/09/16 10:04:10 s/static_library/source_set (they're generally pre s/static_library/source_set (they're generally preferred in GN) felt 2015/09/16 14:41:53 Done. Show quoted text On 2015/09/16 10:04:10, blundell wrote: > s/static_library/source_set (they're generally preferred in GN) Done.
6 sources = [	7 sources = [

7 "about_protocol_handler.cc",	8 "ssl_error_info.cc",

8 "about_protocol_handler.h",	9 "ssl_error_info.h",

9 "url_request_about_job.cc",

10 "url_request_about_job.h",

11 ]	10 ]

12	11

13 deps = [	12 deps = [

14 "//base",	13 "//base",

	14 "//components/strings",

15 "//net",	15 "//net",

	16 "//ui/base",

16 ]	17 ]

17 }	18 }

OLD	NEW