Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: media/filters/chunk_demuxer_unittest.cc

Issue 13419002: Media Source dispatches inband text tracks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporated aaron's comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer_unittest.cc
diff --git a/media/filters/chunk_demuxer_unittest.cc b/media/filters/chunk_demuxer_unittest.cc
index 8a1bc37ac622b368a8e238a436bb42ddf9e41d9f..7516f944c85f4482f2282f94c419276346427e2a 100644
--- a/media/filters/chunk_demuxer_unittest.cc
+++ b/media/filters/chunk_demuxer_unittest.cc
@@ -152,7 +152,10 @@ class ChunkDemuxerTest : public testing::Test {
base::Bind(&ChunkDemuxerTest::DemuxerOpened, base::Unretained(this));
ChunkDemuxer::NeedKeyCB need_key_cb =
base::Bind(&ChunkDemuxerTest::DemuxerNeedKey, base::Unretained(this));
- demuxer_.reset(new ChunkDemuxer(open_cb, need_key_cb, LogCB()));
+ AddTextTrackCB add_text_track_cb =
+ base::Bind(&ChunkDemuxerTest::OnTextTrack, base::Unretained(this));
+ demuxer_.reset(new ChunkDemuxer(open_cb, need_key_cb,
+ add_text_track_cb, LogCB()));
}
virtual ~ChunkDemuxerTest() {
@@ -775,6 +778,13 @@ class ChunkDemuxerTest : public testing::Test {
NeedKeyMock(type, init_data.get(), init_data_size);
}
+ scoped_ptr<TextTrack> OnTextTrack(TextKind kind,
+ const std::string& label,
+ const std::string& language) {
+ // TODO(matthewjheaney): put something here
acolwell GONE FROM CHROMIUM 2013/05/17 16:32:08 nit: Please make it explict what needs to be done
Matthew Heaney (Chromium) 2013/05/18 01:35:48 Done.
+ return scoped_ptr<TextTrack>(0);
acolwell GONE FROM CHROMIUM 2013/05/17 16:32:08 nit: You shouldn't need the 0.
Matthew Heaney (Chromium) 2013/05/18 01:35:48 Done.
+ }
+
base::MessageLoop message_loop_;
MockDemuxerHost host_;

Powered by Google App Engine
This is Rietveld 408576698