Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: webkit/media/webmediaplayer_impl.h

Issue 13419002: Media Source dispatches inband text tracks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporated Frank's comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webmediaplayer_impl.h
diff --git a/webkit/media/webmediaplayer_impl.h b/webkit/media/webmediaplayer_impl.h
index 68e6f3caf9bdaba7e37b924c3b182a7ae6cadc26..208db4646d457aa25e270ec25773d4660fe8eee9 100644
--- a/webkit/media/webmediaplayer_impl.h
+++ b/webkit/media/webmediaplayer_impl.h
@@ -67,6 +67,7 @@ class MediaStreamClient;
class WebAudioSourceProviderImpl;
class WebMediaPlayerDelegate;
class WebMediaPlayerParams;
+class WebInbandTextTrackImpl;
class WebMediaPlayerImpl
: public WebKit::WebMediaPlayer,
@@ -209,6 +210,10 @@ class WebMediaPlayerImpl
const std::string& session_id,
scoped_array<uint8> init_data,
int init_data_size);
+ void OnTextTrack(const media::TextKind kind,
+ const std::string& label,
+ const std::string& language);
+ void OnText(const base::TimeDelta& time);
void SetOpaque(bool);
private:
@@ -362,6 +367,9 @@ class WebMediaPlayerImpl
scoped_refptr<media::GpuVideoDecoder::Factories> gpu_factories_;
+ // TODO(matthewjheaney): resolve cardinality
+ scoped_refptr<WebInbandTextTrackImpl> text_track_;
acolwell GONE FROM CHROMIUM 2013/04/05 16:29:23 I think some crafty Bind()ing can remove the need
Matthew Heaney (Chromium) 2013/05/09 03:53:11 This might be OBE. This is now a set, but it rema
+
DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698