Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webkit/media/webinbandtexttrackprivateclient_impl.cc

Issue 13419002: Media Source dispatches inband text tracks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webinbandtexttrackprivateclient_impl.cc
diff --git a/webkit/media/webinbandtexttrackprivateclient_impl.cc b/webkit/media/webinbandtexttrackprivateclient_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dd38bdb5ad6fe1c90632035dd63a8a74bbbe1980
--- /dev/null
+++ b/webkit/media/webinbandtexttrackprivateclient_impl.cc
@@ -0,0 +1,35 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webinbandtexttrackprivateclient_impl.h"
+// TODO(matthewjheaney): this doesn't compile, because it pulls in color.h
+//#include
+// "third_party/WebKit/Source/WebCore/platform/graphics/
+// InbandTextTrackPrivateClient.h"
+
+namespace webkit_media {
+
+WebInbandTextTrackPrivateClientImpl::WebInbandTextTrackPrivateClientImpl()
+ : client_(NULL) { // TODO(matthewjheaney
+}
+
+WebInbandTextTrackPrivateClientImpl::~WebInbandTextTrackPrivateClientImpl() {
+}
+
+void WebInbandTextTrackPrivateClientImpl::addWebVTTCue(
+ WebKit::WebInbandTextTrackPrivate*, // TODO(matthewjheaney): ?
+ double start,
+ double end,
+ const WebKit::WebString& id,
+ const WebKit::WebString& content,
+ const WebKit::WebString& settings) {
+ // TODO(matthewjheaney):
+ //client_->addWebVTTCue(start,
fgalligan1 2013/04/02 19:38:32 I think this should be client()->addWebVTTCue()
Matthew Heaney (Chromium) 2013/04/04 04:01:52 OBE
+ // end,
+ // id,
+ // content,
+ // settings);
+}
+
+} // namespace webkit_media

Powered by Google App Engine
This is Rietveld 408576698