Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "webkit/media/texttrack_impl.h" | |
| 6 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInbandTextTrackCli ent.h" | |
| 7 #include "webkit/media/webinbandtexttrack_impl.h" | |
| 8 | |
| 9 namespace webkit_media { | |
| 10 | |
| 11 TextTrackImpl::TextTrackImpl(WebInbandTextTrackImpl* text_track) | |
| 12 : text_track_(text_track) { | |
| 13 // This impl object assumes owndership of the text_track object. | |
|
acolwell GONE FROM CHROMIUM
2013/05/17 16:32:08
nit:s/owndership/ownership/
Matthew Heaney (Chromium)
2013/05/18 01:35:48
Done.
| |
| 14 } | |
| 15 | |
| 16 TextTrackImpl::~TextTrackImpl() { | |
| 17 delete text_track_; | |
| 18 } | |
| 19 | |
| 20 void TextTrackImpl::addWebVTTCue(const base::TimeDelta& start, | |
| 21 const base::TimeDelta& end, | |
| 22 const std::string& id, | |
| 23 const std::string& content, | |
| 24 const std::string& settings) { | |
| 25 text_track_->client()->addWebVTTCue(start.InSecondsF(), | |
|
acolwell GONE FROM CHROMIUM
2013/05/17 16:32:08
nit: I think you may need a null check on client()
Matthew Heaney (Chromium)
2013/05/18 01:35:48
Done.
| |
| 26 end.InSecondsF(), | |
| 27 WebKit::WebString::fromUTF8(id), | |
| 28 WebKit::WebString::fromUTF8(content), | |
| 29 WebKit::WebString::fromUTF8(settings)); | |
| 30 } | |
| 31 | |
| 32 } // namespace webkit_media | |
| OLD | NEW |