Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: media/base/android/media_source_player.cc

Issue 1341883003: Prepare MediaDrmBridge to work with MediaCodecPlayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bug526755
Patch Set: Fixed MediaDrmBridgeTest unit tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_source_player.h ('k') | media/base/android/media_task_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_source_player.cc
diff --git a/media/base/android/media_source_player.cc b/media/base/android/media_source_player.cc
index 4551520b25f14950dad1b51d4376767869e70af7..1c117b70dfb86fe4d5938a65897c7031cbbd6370 100644
--- a/media/base/android/media_source_player.cc
+++ b/media/base/android/media_source_player.cc
@@ -18,6 +18,7 @@
#include "media/base/android/audio_decoder_job.h"
#include "media/base/android/media_player_manager.h"
#include "media/base/android/video_decoder_job.h"
+#include "media/base/bind_to_current_loop.h"
#include "media/base/timestamp_constants.h"
namespace media {
@@ -258,9 +259,13 @@ void MediaSourcePlayer::OnDemuxerDurationChanged(base::TimeDelta duration) {
duration_ = duration;
}
-void MediaSourcePlayer::OnMediaCryptoReady() {
+void MediaSourcePlayer::OnMediaCryptoReady(
+ MediaDrmBridge::JavaObjectPtr /* media_crypto */,
+ bool /* needs_protected_surface */) {
+ // Callback parameters are ignored in this player. They are intended for
+ // MediaCodecPlayer which uses a different threading scheme.
DCHECK(!drm_bridge_->GetMediaCrypto().is_null());
- drm_bridge_->SetMediaCryptoReadyCB(base::Closure());
+ drm_bridge_->SetMediaCryptoReadyCB(MediaDrmBridge::MediaCryptoReadyCB());
// Retry decoder creation if the decoders are waiting for MediaCrypto.
RetryDecoderCreation(true, true);
@@ -292,8 +297,9 @@ void MediaSourcePlayer::SetCdm(BrowserCdm* cdm) {
video_decoder_job_->SetDrmBridge(drm_bridge_);
if (drm_bridge_->GetMediaCrypto().is_null()) {
- drm_bridge_->SetMediaCryptoReadyCB(
+ MediaDrmBridge::MediaCryptoReadyCB cb = BindToCurrentLoop(
base::Bind(&MediaSourcePlayer::OnMediaCryptoReady, weak_this_));
+ drm_bridge_->SetMediaCryptoReadyCB(cb);
return;
}
« no previous file with comments | « media/base/android/media_source_player.h ('k') | media/base/android/media_task_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698