Enabling 64-bit mojo shell to launch 32-bit child to handle nonsfi content.

shell/out_of_process_native_runner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "shell/out_of_process_native_runner.h"
 
+#include <string>
+
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
+#include "base/strings/string_util.h"
 #include "shell/child_controller.mojom.h"
 #include "shell/child_process_host.h"
 #include "shell/in_process_native_runner.h"
 
 namespace shell {
 
 OutOfProcessNativeRunner::OutOfProcessNativeRunner(Context* context)
     : context_(context) {
 }
 
 OutOfProcessNativeRunner::~OutOfProcessNativeRunner() {
   if (child_process_host_) {
     // TODO(vtl): Race condition: If |ChildProcessHost::DidStart()| hasn't been
     // called yet, we shouldn't call |Join()| here. (Until |DidStart()|, we may
     // not have a child process to wait on.) Probably we should fix |Join()|.
     child_process_host_->Join();
   }
 }
 
 void OutOfProcessNativeRunner::Start(
     const base::FilePath& app_path,
     mojo::InterfaceRequest<mojo::Application> application_request,
     const base::Closure& app_completed_callback) {
   app_path_ = app_path;
 
   DCHECK(app_completed_callback_.is_null());
   app_completed_callback_ = app_completed_callback;
 
   child_process_host_.reset(new ChildProcessHost(context_));
-  child_process_host_->Start();
+  bool require_32_bit = false;
+  if (EndsWith(app_path.value(), "nacl_content_handler_nonsfi.mojo", true))
+    require_32_bit = true;

[Sean Klein, 2015/09/14 18:10:34]

I am fully aware this is kind of hacky -- mojo people suggested reading ELF
headers to identify if 32-bit child shell is required. That being said, this
version does currently work.

I would be happy to write the ELF-reading code, but I would rather not start
from scratch, since reusing good code is probably better than rolling my own.
Any pointers on which elf util I should be using?

[Mark Seaborn, 2015/09/14 18:38:59]

I think it's up to an owner of this code whether this hack is acceptable.

If you're adding a hack it should at least have a comment to explain what it's
for. :-)
Reading the header is trivial enough that it's not worth adding a dependency.

Have a look at /usr/include/elf.h.

The first 16 bytes of an ELF file are the e_ident header from
Elf32_Ehdr/Elf64_Ehdr.  You could look at the field e_ident[EI_CLASS] to see
whether the file is ELFCLASS32 or ELFCLASS64.

You could start here:
http://sco.com/developers/devspecs/gabi41.pdf
-- See Section 4-4, "ELF Header".
However, this is an old version of the ELF docs which predates ELFCLASS64.

[Sean Klein, 2015/09/15 18:37:50]

Modified to check ELF header of content handler. Alternatively, I could be
checking the ELF header of the content itself, but this is a bit trickier (and
not necessarily and ELF file).

My error handling isn't great at this point, but I'm not sure what else can be
done (it's a void function, but is an assertion the best I can do in case of
error?). Also, should I be checking for the magic ELF header here?

[Mark Seaborn, 2015/09/15 19:42:58]

Yes, checking for "\x7fELF" would be good, to ensure that when you read EI_CLASS
it's meaningful.

+  child_process_host_->Start(require_32_bit);
 
   // TODO(vtl): |app_path.AsUTF8Unsafe()| is unsafe.
   child_process_host_->StartApp(
       app_path.AsUTF8Unsafe(), application_request.Pass(),
       base::Bind(&OutOfProcessNativeRunner::AppCompleted,
                  base::Unretained(this)));
 }
 
 void OutOfProcessNativeRunner::AppCompleted(int32_t result) {
   DVLOG(2) << "OutOfProcessNativeRunner::AppCompleted(" << result << ")";
@@ skipping 10 matching lines @@
 
 scoped_ptr<NativeRunner> OutOfProcessNativeRunnerFactory::Create(
     const Options& options) {
   if (options.force_in_process)
     return make_scoped_ptr(new InProcessNativeRunner(context_));
 
   return make_scoped_ptr(new OutOfProcessNativeRunner(context_));
 }
 
 }  // namespace shell