cmake_build: support SKIA_OUT and BUILDTYPE

cmake_build: support SKIA_OUT and BUILDTYPE

And, fix BUILDTYPE=Debug build.
EQUAL is for numbers, STREQUAL for strings.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/0faed58bc781adc8f21786943ffada1a0fc69b5a

[mtklein_C, 2015-09-14 18:09:30]

mtklein@chromium.org changed reviewers:
+ borenet@google.com

[mtklein_C, 2015-09-14 18:09:30]

Do I need to also worry about multiple bots concurrently bootstrapping CMake in
the same skia/ checkout?

[borenet, 2015-09-14 18:16:00]

As discussed in person, only one builder uses the checkout at a time, but one
out-dir per builder is handy for caching results.

https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build
File cmake/cmake_build (right):

https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
cmake/cmake_build:22: out=${SKIA_OUT:-$here}
I think "out" is a better default.

https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
cmake/cmake_build:33: $here/../third_party/externals/cmake/bin/cmake
-DCMAKE_BUILD_TYPE=$type $here -G Ninja
What's the second $here used for?  Should it be $out instead?

[mtklein, 2015-09-14 18:47:05]

On 2015/09/14 18:16:00, borenet wrote:
> As discussed in person, only one builder uses the checkout at a time, but one
> out-dir per builder is handy for caching results.
> 
> https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build
> File cmake/cmake_build (right):
> 
>
https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
> cmake/cmake_build:22: out=${SKIA_OUT:-$here}
> I think "out" is a better default.

You mean ../out?  I wouldn't want to get anyone confused about mixing cmake
builds and gyp builds.  Everything else so far defaults cmake builds to end up
in skia/cmake.

> 
>
https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
> cmake/cmake_build:33: $here/../third_party/externals/cmake/bin/cmake
> -DCMAKE_BUILD_TYPE=$type $here -G Ninja
> What's the second $here used for?  Should it be $out instead?

Oddly, no.  That's 'where do I find CMakeLists.txt?'.  The fact that I've cd'd
to $out is what puts all the output there.

[mtklein, 2015-09-14 18:47:44]

On 2015/09/14 18:47:05, mtklein wrote:
> On 2015/09/14 18:16:00, borenet wrote:
> > As discussed in person, only one builder uses the checkout at a time, but
one
> > out-dir per builder is handy for caching results.
> > 
> > https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build
> > File cmake/cmake_build (right):
> > 
> >
>
https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
> > cmake/cmake_build:22: out=${SKIA_OUT:-$here}
> > I think "out" is a better default.
> 
> You mean ../out?  I wouldn't want to get anyone confused about mixing cmake
> builds and gyp builds.  Everything else so far defaults cmake builds to end up
> in skia/cmake.
> 
> > 
> >
>
https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
> > cmake/cmake_build:33: $here/../third_party/externals/cmake/bin/cmake
> > -DCMAKE_BUILD_TYPE=$type $here -G Ninja
> > What's the second $here used for?  Should it be $out instead?
> 
> Oddly, no.  That's 'where do I find CMakeLists.txt?'.  The fact that I've cd'd
> to $out is what puts all the output there.

Do the bots always set BUILDTYPE and SKIA_OUT?  If so, I'll just assert they're
set instead of defaults.

[mtklein_C, 2015-09-14 18:52:53]

> Do the bots always set BUILDTYPE and SKIA_OUT?  If so, I'll just assert
they're
> set instead of defaults.

PS 3 now requires BUILDTYPE and SKIA_OUT.

[borenet, 2015-09-14 18:54:12]

On 2015/09/14 18:47:44, mtklein wrote:
> On 2015/09/14 18:47:05, mtklein wrote:
> > On 2015/09/14 18:16:00, borenet wrote:
> > > As discussed in person, only one builder uses the checkout at a time, but
> one
> > > out-dir per builder is handy for caching results.
> > > 
> > > https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build
> > > File cmake/cmake_build (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
> > > cmake/cmake_build:22: out=${SKIA_OUT:-$here}
> > > I think "out" is a better default.
> > 
> > You mean ../out?  I wouldn't want to get anyone confused about mixing cmake
> > builds and gyp builds.  Everything else so far defaults cmake builds to end
up
> > in skia/cmake.
> > 

Yeah, that's what I was thinking.  Personally, I tend to expect my build outputs
to end up in $skia/out, so having them elsewhere would be confusing to me. 
Maybe default to $skia/out/cmake?  I don't feel particularly strongly either
way.

> > > 
> > >
> >
>
https://codereview.chromium.org/1341763003/diff/20001/cmake/cmake_build#newco...
> > > cmake/cmake_build:33: $here/../third_party/externals/cmake/bin/cmake
> > > -DCMAKE_BUILD_TYPE=$type $here -G Ninja
> > > What's the second $here used for?  Should it be $out instead?
> > 
> > Oddly, no.  That's 'where do I find CMakeLists.txt?'.  The fact that I've
cd'd
> > to $out is what puts all the output there.
> 
> Do the bots always set BUILDTYPE and SKIA_OUT?  If so, I'll just assert
they're
> set instead of defaults.

As far as I can remember, yes, the bots always set those.  For consistency's
sake, I'd vote we set defaults like the Makefile:
https://skia.googlesource.com/skia/+/master/Makefile

[borenet, 2015-09-14 18:56:26]

LGTM

[mtklein, 2015-09-14 18:56:34]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-09-14 18:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341763003/40001

[commit-bot: I haz the power, 2015-09-14 19:02:35]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0faed58bc781adc8f21786943ffada1a0fc69b5a