Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1341763002: elements.cc CopyDoubleToObjectElements: avoid excessive HandleScopes (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

elements.cc CopyDoubleToObjectElements: avoid excessive HandleScopes BUG= Committed: https://crrev.com/43a04030b8c71549ef7608fe831d6633918dd52c Cr-Commit-Position: refs/heads/master@{#30717}

Patch Set 1 #

Patch Set 2 : Extending comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M src/elements.cc View 1 1 chunk +15 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Camillo Bruni
PTAL Tight loops with HandleScopes are not a good idea :)
5 years, 3 months ago (2015-09-14 13:30:42 UTC) #2
mvstanton
Nice, LGTM. :)
5 years, 3 months ago (2015-09-14 13:56:51 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341763002/20001
5 years, 3 months ago (2015-09-14 14:00:48 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 14:24:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341763002/20001
5 years, 3 months ago (2015-09-14 14:28:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 14:29:53 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 14:30:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43a04030b8c71549ef7608fe831d6633918dd52c
Cr-Commit-Position: refs/heads/master@{#30717}

Powered by Google App Engine
This is Rietveld 408576698