Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1341753003: SkValidatingReadBuffer: make sure we don't call readTypeface(). (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkValidatingReadBuffer: make sure we don't call readTypeface(). Add an assert to make sure we're not calling this unimplemented method. BUG=skia:3978 Committed: https://skia.googlesource.com/skia/+/a46ada5635351cf3ceefa1a3570212a21c2a8224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341753003/1
5 years, 3 months ago (2015-09-14 14:01:21 UTC) #2
mtklein_C
5 years, 3 months ago (2015-09-14 14:03:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 14:07:02 UTC) #6
reed1
lgtm
5 years, 3 months ago (2015-09-14 17:48:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341753003/1
5 years, 3 months ago (2015-09-14 18:09:11 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 18:09:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a46ada5635351cf3ceefa1a3570212a21c2a8224

Powered by Google App Engine
This is Rietveld 408576698