pkg/scheduled_test/test/descriptor_test.dart - Issue 13417002: Mark scheduled_server_test as flaky and increase the timeout on the other scheduled tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/test/descriptor_test.dart

Issue 13417002: Mark scheduled_server_test as flaky and increase the timeout on the other scheduled tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/scheduled_test/test/descriptor_test.dart

diff --git a/pkg/scheduled_test/test/descriptor_test.dart b/pkg/scheduled_test/test/descriptor_test.dart

index f43e159476f298318a7d5ef2e1923918b533c97d..5c8bc64150313265f5504520d061c2ac156d76ec 100644

--- a/pkg/scheduled_test/test/descriptor_test.dart

+++ b/pkg/scheduled_test/test/descriptor_test.dart

@@ -18,8 +18,9 @@ String sandbox;

void main() {

metaSetUp(() {

- // The windows bots are very slow, so we increase the default timeout.

- if (Platform.operatingSystem != "windows") return;

+ // TODO(nweiz): We used to only increase the timeout to 10s for the Windows

+ // bots, but the Linux and Mac bots have started taking upwards of 5s when

+ // running pumpEventQueue, so we're increasing the timeout across the board.

Bob Nystrom 2013/04/02 00:45:22 Mention the bug number here.

nweiz 2013/04/02 00:50:00 Done.

currentSchedule.timeout = new Duration(seconds: 10);

});

« no previous file with comments | « pkg/pkg.status ('k') | pkg/scheduled_test/test/scheduled_test_test.dart » ('j') | no next file with comments »