Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views.h

Issue 134163014: Added tests for views flavor of MediaGalleriesDialogTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comment for ownership of contents_ when testing. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/media_galleries_dialog_views.h
diff --git a/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h b/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h
index a57756b049635c0e1e331835cd6e57424a1af486..ff21bffe1db91ca6f6f499b049e69aa17b40a984 100644
--- a/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h
+++ b/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h
@@ -60,9 +60,16 @@ class MediaGalleriesDialogViews : public MediaGalleriesDialog,
ui::MenuSourceType source_type) OVERRIDE;
private:
+ FRIEND_TEST_ALL_PREFIXES(MediaGalleriesDialogTest, InitializeCheckboxes);
+ FRIEND_TEST_ALL_PREFIXES(MediaGalleriesDialogTest, ToggleCheckboxes);
+ FRIEND_TEST_ALL_PREFIXES(MediaGalleriesDialogTest, UpdateAdds);
+ FRIEND_TEST_ALL_PREFIXES(MediaGalleriesDialogTest, ForgetDeletes);
+
typedef std::map<MediaGalleryPrefId, views::Checkbox*> CheckboxMap;
typedef std::map<views::Checkbox*, MediaGalleryPrefInfo> NewCheckboxMap;
+ void ButtonPressedAction(views::Button* sender);
+
void InitChildViews();
// Adds a checkbox or updates an existing checkbox. Returns true if a new one
@@ -81,7 +88,7 @@ class MediaGalleriesDialogViews : public MediaGalleriesDialog,
// The containing window (a weak pointer).
views::Widget* window_;
- // The contents of the dialog. Owned by |window_|'s RootView.
+ // The contents of the dialog. Owned by |window_|'s RootView except for tests.
views::View* contents_;
// A map from media gallery ID to views::Checkbox view.
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698