Added tests for views flavor of MediaGalleriesDialogTest.

chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[vandebo (ex-Chrome), 2014/02/11 18:26:24]

no (c)

[Sheridan Rawlins, 2014/02/13 04:57:20]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock.h"
 #include "chrome/browser/storage_monitor/storage_info.h"
-#include "chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.h"
+#include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/views/controls/button/checkbox.h"
 
 using ::testing::_;
 using ::testing::NiceMock;
 using ::testing::Return;
 using ::testing::ReturnPointee;
-using ::testing::ReturnRef;
 
 namespace {
 
 MediaGalleryPrefInfo MakePrefInfoForTesting(MediaGalleryPrefId id) {
   MediaGalleryPrefInfo gallery;
   gallery.pref_id = id;
   gallery.device_id = StorageInfo::MakeDeviceId(StorageInfo::FIXED_MASS_STORAGE,
                                                 base::Int64ToString(id));
   gallery.display_name = base::ASCIIToUTF16("Display Name");
   return gallery;
@@ skipping 36 matching lines @@
       MediaGalleriesDialogController::GalleryPermission(
           MakePrefInfoForTesting(2), false));
   EXPECT_CALL(controller, AttachedPermissions()).
       WillRepeatedly(Return(attached_permissions));
 
   MediaGalleriesDialogController::GalleryPermissionsVector
       unattached_permissions;
   EXPECT_CALL(controller, UnattachedPermissions()).
       WillRepeatedly(Return(unattached_permissions));
 
-  MediaGalleriesDialogGtk dialog(&controller);
+  MediaGalleriesDialogViews dialog(&controller);
   EXPECT_EQ(2U, dialog.checkbox_map_.size());
 
-  GtkWidget* checkbox1 = dialog.checkbox_map_[1];
-  ASSERT_TRUE(GTK_IS_TOGGLE_BUTTON(checkbox1));
-  EXPECT_TRUE(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(checkbox1)));
+  views::Checkbox* checkbox1 = dialog.checkbox_map_[1];
+  EXPECT_TRUE(checkbox1->checked());
 
-  GtkWidget* checkbox2 = dialog.checkbox_map_[2];
-  ASSERT_TRUE(GTK_IS_TOGGLE_BUTTON(checkbox2));
-  EXPECT_FALSE(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(checkbox2)));
+  views::Checkbox* checkbox2 = dialog.checkbox_map_[2];
+  EXPECT_FALSE(checkbox2->checked());
 }
 
 // Tests that toggling checkboxes updates the controller.
 TEST_F(MediaGalleriesDialogTest, ToggleCheckboxes) {
   NiceMock<MediaGalleriesDialogControllerMock> controller(dummy_extension());
 
   MediaGalleriesDialogController::GalleryPermissionsVector attached_permissions;
   attached_permissions.push_back(
       MediaGalleriesDialogController::GalleryPermission(
           MakePrefInfoForTesting(1), true));
   EXPECT_CALL(controller, AttachedPermissions()).
       WillRepeatedly(Return(attached_permissions));
 
   MediaGalleriesDialogController::GalleryPermissionsVector
       unattached_permissions;
   EXPECT_CALL(controller, UnattachedPermissions()).
       WillRepeatedly(Return(unattached_permissions));
 
-  MediaGalleriesDialogGtk dialog(&controller);
+  MediaGalleriesDialogViews dialog(&controller);
   EXPECT_EQ(1U, dialog.checkbox_map_.size());
-  GtkWidget* checkbox =
-      dialog.checkbox_map_[1];
-  ASSERT_TRUE(GTK_IS_TOGGLE_BUTTON(checkbox));
-  EXPECT_TRUE(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(checkbox)));
+  views::Checkbox* checkbox = dialog.checkbox_map_[1];
+  EXPECT_TRUE(checkbox->checked());
 
   EXPECT_CALL(controller, DidToggleGalleryId(1, false));
-  gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(checkbox), FALSE);
+  checkbox->SetChecked(false);
+  dialog.ButtonPressedAction(checkbox);
 
   EXPECT_CALL(controller, DidToggleGalleryId(1, true));
-  gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(checkbox), TRUE);
+  checkbox->SetChecked(true);
+  dialog.ButtonPressedAction(checkbox);
 }
 
 // Tests that UpdateGallery will add a new checkbox, but only if it refers to
 // a gallery that the dialog hasn't seen before.
 TEST_F(MediaGalleriesDialogTest, UpdateAdds) {
   NiceMock<MediaGalleriesDialogControllerMock> controller(dummy_extension());
 
   MediaGalleriesDialogController::GalleryPermissionsVector attached_permissions;
   EXPECT_CALL(controller, AttachedPermissions()).
       WillRepeatedly(ReturnPointee(&attached_permissions));
 
   MediaGalleriesDialogController::GalleryPermissionsVector
       unattached_permissions;
   EXPECT_CALL(controller, UnattachedPermissions()).
       WillRepeatedly(Return(unattached_permissions));
 
-  MediaGalleriesDialogGtk dialog(&controller);
+  MediaGalleriesDialogViews dialog(&controller);
 
   EXPECT_TRUE(dialog.checkbox_map_.empty());
 
   MediaGalleryPrefInfo gallery1 = MakePrefInfoForTesting(1);
   attached_permissions.push_back(
       MediaGalleriesDialogController::GalleryPermission(gallery1, true));
   dialog.UpdateGalleries();
   EXPECT_EQ(1U, dialog.checkbox_map_.size());
 
   MediaGalleryPrefInfo gallery2 = MakePrefInfoForTesting(2);
@@ skipping 13 matching lines @@
 
   MediaGalleriesDialogController::GalleryPermissionsVector attached_permissions;
   EXPECT_CALL(controller, AttachedPermissions()).
       WillRepeatedly(ReturnPointee(&attached_permissions));
 
   MediaGalleriesDialogController::GalleryPermissionsVector
       unattached_permissions;
   EXPECT_CALL(controller, UnattachedPermissions()).
       WillRepeatedly(Return(unattached_permissions));
 
-  MediaGalleriesDialogGtk dialog(&controller);
+  MediaGalleriesDialogViews dialog(&controller);
 
   EXPECT_TRUE(dialog.checkbox_map_.empty());
 
   MediaGalleryPrefInfo gallery1 = MakePrefInfoForTesting(1);
   attached_permissions.push_back(
       MediaGalleriesDialogController::GalleryPermission(gallery1, true));
   dialog.UpdateGalleries();
   EXPECT_EQ(1U, dialog.checkbox_map_.size());
 
   MediaGalleryPrefInfo gallery2 = MakePrefInfoForTesting(2);
   attached_permissions.push_back(
       MediaGalleriesDialogController::GalleryPermission(gallery2, true));
   dialog.UpdateGalleries();
   EXPECT_EQ(2U, dialog.checkbox_map_.size());
 
   attached_permissions.pop_back();
   dialog.UpdateGalleries();
   EXPECT_EQ(1U, dialog.checkbox_map_.size());
 }