src/core/SkPicturePlayback.h - Issue 134163010: Refactor read and write buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicturePlayback.h

Issue 134163010: Refactor read and write buffers. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: whoops, read buffers have .size() Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPicturePlayback.h

diff --git a/src/core/SkPicturePlayback.h b/src/core/SkPicturePlayback.h

index 1cff0f9e0edd73518324c81b4666bc43f0b4368c..efa67225b53903534023de6d7b5cc4765bf62ee6 100644

--- a/src/core/SkPicturePlayback.h

+++ b/src/core/SkPicturePlayback.h

@@ -14,7 +14,7 @@

#include "SkBitmap.h"

#include "SkData.h"

#include "SkMatrix.h"

-#include "SkOrderedReadBuffer.h"

+#include "SkReadBuffer.h"

#include "SkPaint.h"

#include "SkPath.h"

#include "SkPathHeap.h"

@@ -192,8 +192,8 @@ public:

private: // these help us with reading/writing

bool parseStreamTag(SkStream*, const SkPictInfo&, uint32_t tag, size_t size,

SkPicture::InstallPixelRefProc);

- bool parseBufferTag(SkOrderedReadBuffer&, uint32_t tag, size_t size);

- void flattenToBuffer(SkOrderedWriteBuffer&) const;

+ bool parseBufferTag(SkReadBuffer&, uint32_t tag, size_t size);

+ void flattenToBuffer(SkWriteBuffer&) const;

private:

// Only used by getBitmap() if the passed in index is SkBitmapHeap::INVALID_SLOT. This empty

« no previous file with comments | « src/core/SkPictureFlat.h ('k') | src/core/SkPicturePlayback.cpp » ('j') | no next file with comments »