Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: src/effects/SkRectShaderImageFilter.cpp

Issue 134163010: Refactor read and write buffers. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: original write flags were fine Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkRectShaderImageFilter.h" 8 #include "SkRectShaderImageFilter.h"
9 #include "SkBitmap.h" 9 #include "SkBitmap.h"
10 #include "SkCanvas.h" 10 #include "SkCanvas.h"
11 #include "SkDevice.h" 11 #include "SkDevice.h"
12 #include "SkFlattenableBuffers.h" 12 #include "SkReadBuffer.h"
13 #include "SkWriteBuffer.h"
13 #include "SkShader.h" 14 #include "SkShader.h"
14 15
15 SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const SkRe ct& rect) { 16 SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const SkRe ct& rect) {
16 SkASSERT(s); 17 SkASSERT(s);
17 uint32_t flags = CropRect::kHasAll_CropEdge; 18 uint32_t flags = CropRect::kHasAll_CropEdge;
18 if (rect.width() == 0 || rect.height() == 0) { 19 if (rect.width() == 0 || rect.height() == 0) {
19 flags = 0x0; 20 flags = 0x0;
20 } 21 }
21 CropRect cropRect(rect, flags); 22 CropRect cropRect(rect, flags);
22 return SkNEW_ARGS(SkRectShaderImageFilter, (s, &cropRect)); 23 return SkNEW_ARGS(SkRectShaderImageFilter, (s, &cropRect));
23 } 24 }
24 25
25 SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const Crop Rect* cropRect) { 26 SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const Crop Rect* cropRect) {
26 SkASSERT(s); 27 SkASSERT(s);
27 return SkNEW_ARGS(SkRectShaderImageFilter, (s, cropRect)); 28 return SkNEW_ARGS(SkRectShaderImageFilter, (s, cropRect));
28 } 29 }
29 30
30 SkRectShaderImageFilter::SkRectShaderImageFilter(SkShader* s, const CropRect* cr opRect) 31 SkRectShaderImageFilter::SkRectShaderImageFilter(SkShader* s, const CropRect* cr opRect)
31 : INHERITED(NULL, cropRect) 32 : INHERITED(NULL, cropRect)
32 , fShader(s) { 33 , fShader(s) {
33 SkASSERT(s); 34 SkASSERT(s);
34 s->ref(); 35 s->ref();
35 } 36 }
36 37
37 SkRectShaderImageFilter::SkRectShaderImageFilter(SkFlattenableReadBuffer& buffer ) 38 SkRectShaderImageFilter::SkRectShaderImageFilter(SkReadBuffer& buffer)
38 : INHERITED(1, buffer) { 39 : INHERITED(1, buffer) {
39 fShader = buffer.readShader(); 40 fShader = buffer.readShader();
40 } 41 }
41 42
42 void SkRectShaderImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const { 43 void SkRectShaderImageFilter::flatten(SkWriteBuffer& buffer) const {
43 this->INHERITED::flatten(buffer); 44 this->INHERITED::flatten(buffer);
44 45
45 buffer.writeFlattenable(fShader); 46 buffer.writeFlattenable(fShader);
46 } 47 }
47 48
48 SkRectShaderImageFilter::~SkRectShaderImageFilter() { 49 SkRectShaderImageFilter::~SkRectShaderImageFilter() {
49 SkSafeUnref(fShader); 50 SkSafeUnref(fShader);
50 } 51 }
51 52
52 bool SkRectShaderImageFilter::onFilterImage(Proxy* proxy, 53 bool SkRectShaderImageFilter::onFilterImage(Proxy* proxy,
(...skipping 18 matching lines...) Expand all
71 SkMatrix matrix; 72 SkMatrix matrix;
72 matrix.setTranslate(-SkIntToScalar(bounds.fLeft), -SkIntToScalar(bounds.fTop )); 73 matrix.setTranslate(-SkIntToScalar(bounds.fLeft), -SkIntToScalar(bounds.fTop ));
73 fShader->setLocalMatrix(matrix); 74 fShader->setLocalMatrix(matrix);
74 SkRect rect = SkRect::MakeWH(SkIntToScalar(bounds.width()), SkIntToScalar(bo unds.height())); 75 SkRect rect = SkRect::MakeWH(SkIntToScalar(bounds.width()), SkIntToScalar(bo unds.height()));
75 canvas.drawRect(rect, paint); 76 canvas.drawRect(rect, paint);
76 *result = device.get()->accessBitmap(false); 77 *result = device.get()->accessBitmap(false);
77 offset->fX = bounds.fLeft; 78 offset->fX = bounds.fLeft;
78 offset->fY = bounds.fTop; 79 offset->fY = bounds.fTop;
79 return true; 80 return true;
80 } 81 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698