Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: src/effects/SkPerlinNoiseShader.cpp

Issue 134163010: Refactor read and write buffers. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: original write flags were fine Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkDither.h" 8 #include "SkDither.h"
9 #include "SkPerlinNoiseShader.h" 9 #include "SkPerlinNoiseShader.h"
10 #include "SkColorFilter.h" 10 #include "SkColorFilter.h"
11 #include "SkFlattenableBuffers.h" 11 #include "SkReadBuffer.h"
12 #include "SkWriteBuffer.h"
12 #include "SkShader.h" 13 #include "SkShader.h"
13 #include "SkUnPreMultiply.h" 14 #include "SkUnPreMultiply.h"
14 #include "SkString.h" 15 #include "SkString.h"
15 16
16 #if SK_SUPPORT_GPU 17 #if SK_SUPPORT_GPU
17 #include "GrContext.h" 18 #include "GrContext.h"
18 #include "GrCoordTransform.h" 19 #include "GrCoordTransform.h"
19 #include "gl/GrGLEffect.h" 20 #include "gl/GrGLEffect.h"
20 #include "GrTBackendEffectFactory.h" 21 #include "GrTBackendEffectFactory.h"
21 #include "SkGr.h" 22 #include "SkGr.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 , fNumOctaves(numOctaves > 255 ? 255 : numOctaves/*[0,255] octaves allowed*/) 287 , fNumOctaves(numOctaves > 255 ? 255 : numOctaves/*[0,255] octaves allowed*/)
287 , fSeed(seed) 288 , fSeed(seed)
288 , fStitchTiles((tileSize != NULL) && !tileSize->isEmpty()) 289 , fStitchTiles((tileSize != NULL) && !tileSize->isEmpty())
289 , fPaintingData(NULL) 290 , fPaintingData(NULL)
290 { 291 {
291 SkASSERT(numOctaves >= 0 && numOctaves < 256); 292 SkASSERT(numOctaves >= 0 && numOctaves < 256);
292 setTileSize(fStitchTiles ? *tileSize : SkISize::Make(0,0)); 293 setTileSize(fStitchTiles ? *tileSize : SkISize::Make(0,0));
293 fMatrix.reset(); 294 fMatrix.reset();
294 } 295 }
295 296
296 SkPerlinNoiseShader::SkPerlinNoiseShader(SkFlattenableReadBuffer& buffer) : 297 SkPerlinNoiseShader::SkPerlinNoiseShader(SkReadBuffer& buffer) :
297 INHERITED(buffer), fPaintingData(NULL) { 298 INHERITED(buffer), fPaintingData(NULL) {
298 fType = (SkPerlinNoiseShader::Type) buffer.readInt(); 299 fType = (SkPerlinNoiseShader::Type) buffer.readInt();
299 fBaseFrequencyX = buffer.readScalar(); 300 fBaseFrequencyX = buffer.readScalar();
300 fBaseFrequencyY = buffer.readScalar(); 301 fBaseFrequencyY = buffer.readScalar();
301 fNumOctaves = buffer.readInt(); 302 fNumOctaves = buffer.readInt();
302 fSeed = buffer.readScalar(); 303 fSeed = buffer.readScalar();
303 fStitchTiles = buffer.readBool(); 304 fStitchTiles = buffer.readBool();
304 fTileSize.fWidth = buffer.readInt(); 305 fTileSize.fWidth = buffer.readInt();
305 fTileSize.fHeight = buffer.readInt(); 306 fTileSize.fHeight = buffer.readInt();
306 setTileSize(fTileSize); 307 setTileSize(fTileSize);
307 fMatrix.reset(); 308 fMatrix.reset();
308 buffer.validate(perlin_noise_type_is_valid(fType) && 309 buffer.validate(perlin_noise_type_is_valid(fType) &&
309 (fNumOctaves >= 0) && (fNumOctaves <= 255)); 310 (fNumOctaves >= 0) && (fNumOctaves <= 255));
310 } 311 }
311 312
312 SkPerlinNoiseShader::~SkPerlinNoiseShader() { 313 SkPerlinNoiseShader::~SkPerlinNoiseShader() {
313 // Safety, should have been done in endContext() 314 // Safety, should have been done in endContext()
314 SkDELETE(fPaintingData); 315 SkDELETE(fPaintingData);
315 } 316 }
316 317
317 void SkPerlinNoiseShader::flatten(SkFlattenableWriteBuffer& buffer) const { 318 void SkPerlinNoiseShader::flatten(SkWriteBuffer& buffer) const {
318 this->INHERITED::flatten(buffer); 319 this->INHERITED::flatten(buffer);
319 buffer.writeInt((int) fType); 320 buffer.writeInt((int) fType);
320 buffer.writeScalar(fBaseFrequencyX); 321 buffer.writeScalar(fBaseFrequencyX);
321 buffer.writeScalar(fBaseFrequencyY); 322 buffer.writeScalar(fBaseFrequencyY);
322 buffer.writeInt(fNumOctaves); 323 buffer.writeInt(fNumOctaves);
323 buffer.writeScalar(fSeed); 324 buffer.writeScalar(fSeed);
324 buffer.writeBool(fStitchTiles); 325 buffer.writeBool(fStitchTiles);
325 buffer.writeInt(fTileSize.fWidth); 326 buffer.writeInt(fTileSize.fWidth);
326 buffer.writeInt(fTileSize.fHeight); 327 buffer.writeInt(fTileSize.fHeight);
327 } 328 }
(...skipping 1056 matching lines...) Expand 10 before | Expand all | Expand 10 after
1384 str->append(" seed: "); 1385 str->append(" seed: ");
1385 str->appendScalar(fSeed); 1386 str->appendScalar(fSeed);
1386 str->append(" stitch tiles: "); 1387 str->append(" stitch tiles: ");
1387 str->append(fStitchTiles ? "true " : "false "); 1388 str->append(fStitchTiles ? "true " : "false ");
1388 1389
1389 this->INHERITED::toString(str); 1390 this->INHERITED::toString(str);
1390 1391
1391 str->append(")"); 1392 str->append(")");
1392 } 1393 }
1393 #endif 1394 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698