Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/effects/SkMatrixConvolutionImageFilter.cpp

Issue 134163010: Refactor read and write buffers. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: original write flags were fine Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The Android Open Source Project 2 * Copyright 2012 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkMatrixConvolutionImageFilter.h" 8 #include "SkMatrixConvolutionImageFilter.h"
9 #include "SkBitmap.h" 9 #include "SkBitmap.h"
10 #include "SkColorPriv.h" 10 #include "SkColorPriv.h"
11 #include "SkFlattenableBuffers.h" 11 #include "SkReadBuffer.h"
12 #include "SkWriteBuffer.h"
12 #include "SkRect.h" 13 #include "SkRect.h"
13 #include "SkUnPreMultiply.h" 14 #include "SkUnPreMultiply.h"
14 15
15 #if SK_SUPPORT_GPU 16 #if SK_SUPPORT_GPU
16 #include "gl/GrGLEffect.h" 17 #include "gl/GrGLEffect.h"
17 #include "effects/GrSingleTextureEffect.h" 18 #include "effects/GrSingleTextureEffect.h"
18 #include "GrTBackendEffectFactory.h" 19 #include "GrTBackendEffectFactory.h"
19 #include "GrTexture.h" 20 #include "GrTexture.h"
20 #include "SkMatrix.h" 21 #include "SkMatrix.h"
21 #endif 22 #endif
(...skipping 28 matching lines...) Expand all
50 fTileMode(tileMode), 51 fTileMode(tileMode),
51 fConvolveAlpha(convolveAlpha) { 52 fConvolveAlpha(convolveAlpha) {
52 uint32_t size = fKernelSize.fWidth * fKernelSize.fHeight; 53 uint32_t size = fKernelSize.fWidth * fKernelSize.fHeight;
53 fKernel = SkNEW_ARRAY(SkScalar, size); 54 fKernel = SkNEW_ARRAY(SkScalar, size);
54 memcpy(fKernel, kernel, size * sizeof(SkScalar)); 55 memcpy(fKernel, kernel, size * sizeof(SkScalar));
55 SkASSERT(kernelSize.fWidth >= 1 && kernelSize.fHeight >= 1); 56 SkASSERT(kernelSize.fWidth >= 1 && kernelSize.fHeight >= 1);
56 SkASSERT(target.fX >= 0 && target.fX < kernelSize.fWidth); 57 SkASSERT(target.fX >= 0 && target.fX < kernelSize.fWidth);
57 SkASSERT(target.fY >= 0 && target.fY < kernelSize.fHeight); 58 SkASSERT(target.fY >= 0 && target.fY < kernelSize.fHeight);
58 } 59 }
59 60
60 SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(SkFlattenableRead Buffer& buffer) 61 SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(SkReadBuffer& buf fer)
61 : INHERITED(1, buffer) { 62 : INHERITED(1, buffer) {
62 // We need to be able to read at most SK_MaxS32 bytes, so divide that 63 // We need to be able to read at most SK_MaxS32 bytes, so divide that
63 // by the size of a scalar to know how many scalars we can read. 64 // by the size of a scalar to know how many scalars we can read.
64 static const int32_t kMaxSize = SK_MaxS32 / sizeof(SkScalar); 65 static const int32_t kMaxSize = SK_MaxS32 / sizeof(SkScalar);
65 fKernelSize.fWidth = buffer.readInt(); 66 fKernelSize.fWidth = buffer.readInt();
66 fKernelSize.fHeight = buffer.readInt(); 67 fKernelSize.fHeight = buffer.readInt();
67 if ((fKernelSize.fWidth >= 1) && (fKernelSize.fHeight >= 1) && 68 if ((fKernelSize.fWidth >= 1) && (fKernelSize.fHeight >= 1) &&
68 // Make sure size won't be larger than a signed int, 69 // Make sure size won't be larger than a signed int,
69 // which would still be extremely large for a kernel, 70 // which would still be extremely large for a kernel,
70 // but we don't impose a hard limit for kernel size 71 // but we don't impose a hard limit for kernel size
(...skipping 10 matching lines...) Expand all
81 fTarget.fX = buffer.readInt(); 82 fTarget.fX = buffer.readInt();
82 fTarget.fY = buffer.readInt(); 83 fTarget.fY = buffer.readInt();
83 fTileMode = (TileMode) buffer.readInt(); 84 fTileMode = (TileMode) buffer.readInt();
84 fConvolveAlpha = buffer.readBool(); 85 fConvolveAlpha = buffer.readBool();
85 buffer.validate((fKernel != 0) && 86 buffer.validate((fKernel != 0) &&
86 SkScalarIsFinite(fGain) && 87 SkScalarIsFinite(fGain) &&
87 SkScalarIsFinite(fBias) && 88 SkScalarIsFinite(fBias) &&
88 tile_mode_is_valid(fTileMode)); 89 tile_mode_is_valid(fTileMode));
89 } 90 }
90 91
91 void SkMatrixConvolutionImageFilter::flatten(SkFlattenableWriteBuffer& buffer) c onst { 92 void SkMatrixConvolutionImageFilter::flatten(SkWriteBuffer& buffer) const {
92 this->INHERITED::flatten(buffer); 93 this->INHERITED::flatten(buffer);
93 buffer.writeInt(fKernelSize.fWidth); 94 buffer.writeInt(fKernelSize.fWidth);
94 buffer.writeInt(fKernelSize.fHeight); 95 buffer.writeInt(fKernelSize.fHeight);
95 buffer.writeScalarArray(fKernel, fKernelSize.fWidth * fKernelSize.fHeight); 96 buffer.writeScalarArray(fKernel, fKernelSize.fWidth * fKernelSize.fHeight);
96 buffer.writeScalar(fGain); 97 buffer.writeScalar(fGain);
97 buffer.writeScalar(fBias); 98 buffer.writeScalar(fBias);
98 buffer.writeInt(fTarget.fX); 99 buffer.writeInt(fTarget.fX);
99 buffer.writeInt(fTarget.fY); 100 buffer.writeInt(fTarget.fY);
100 buffer.writeInt((int) fTileMode); 101 buffer.writeInt((int) fTileMode);
101 buffer.writeBool(fConvolveAlpha); 102 buffer.writeBool(fConvolveAlpha);
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 fBias, 664 fBias,
664 fTarget, 665 fTarget,
665 fTileMode, 666 fTileMode,
666 fConvolveAlpha); 667 fConvolveAlpha);
667 return true; 668 return true;
668 } 669 }
669 670
670 /////////////////////////////////////////////////////////////////////////////// 671 ///////////////////////////////////////////////////////////////////////////////
671 672
672 #endif 673 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698