Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Side by Side Diff: src/core/SkImageInfo.cpp

Issue 134163010: Refactor read and write buffers. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: original write flags were fine Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2010 Google Inc. 2 * Copyright 2010 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkImageInfo.h" 8 #include "SkImageInfo.h"
9 #include "SkFlattenableBuffers.h" 9 #include "SkReadBuffer.h"
10 #include "SkWriteBuffer.h"
10 11
11 static bool alpha_type_is_valid(SkAlphaType alphaType) { 12 static bool alpha_type_is_valid(SkAlphaType alphaType) {
12 return (alphaType >= 0) && (alphaType <= kLastEnum_SkAlphaType); 13 return (alphaType >= 0) && (alphaType <= kLastEnum_SkAlphaType);
13 } 14 }
14 15
15 static bool color_type_is_valid(SkColorType colorType) { 16 static bool color_type_is_valid(SkColorType colorType) {
16 return (colorType >= 0) && (colorType <= kLastEnum_SkColorType); 17 return (colorType >= 0) && (colorType <= kLastEnum_SkColorType);
17 } 18 }
18 19
19 void SkImageInfo::unflatten(SkFlattenableReadBuffer& buffer) { 20 void SkImageInfo::unflatten(SkReadBuffer& buffer) {
20 fWidth = buffer.read32(); 21 fWidth = buffer.read32();
21 fHeight = buffer.read32(); 22 fHeight = buffer.read32();
22 23
23 uint32_t packed = buffer.read32(); 24 uint32_t packed = buffer.read32();
24 SkASSERT(0 == (packed >> 16)); 25 SkASSERT(0 == (packed >> 16));
25 fAlphaType = (SkAlphaType)((packed >> 8) & 0xFF); 26 fAlphaType = (SkAlphaType)((packed >> 8) & 0xFF);
26 fColorType = (SkColorType)((packed >> 0) & 0xFF); 27 fColorType = (SkColorType)((packed >> 0) & 0xFF);
27 buffer.validate(alpha_type_is_valid(fAlphaType) && 28 buffer.validate(alpha_type_is_valid(fAlphaType) &&
28 color_type_is_valid(fColorType)); 29 color_type_is_valid(fColorType));
29 } 30 }
30 31
31 void SkImageInfo::flatten(SkFlattenableWriteBuffer& buffer) const { 32 void SkImageInfo::flatten(SkWriteBuffer& buffer) const {
32 buffer.write32(fWidth); 33 buffer.write32(fWidth);
33 buffer.write32(fHeight); 34 buffer.write32(fHeight);
34 35
35 SkASSERT(0 == (fAlphaType & ~0xFF)); 36 SkASSERT(0 == (fAlphaType & ~0xFF));
36 SkASSERT(0 == (fColorType & ~0xFF)); 37 SkASSERT(0 == (fColorType & ~0xFF));
37 uint32_t packed = (fAlphaType << 8) | fColorType; 38 uint32_t packed = (fAlphaType << 8) | fColorType;
38 buffer.write32(packed); 39 buffer.write32(packed);
39 } 40 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698