components/plugins/renderer/loadable_plugin_placeholder.cc - Issue 1341563002: Plugin Power Saver: Improve origin handling esp. with OOPIF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.cc

Issue 1341563002: Plugin Power Saver: Improve origin handling esp. with OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/plugins/plugin_power_saver_browsertest.cc ('K') | « chrome/browser/plugins/plugin_power_saver_browsertest.cc ('k') | content/browser/plugin_content_origin_whitelist.h » ('j') | content/renderer/pepper/plugin_power_saver_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/loadable_plugin_placeholder.cc

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.cc b/components/plugins/renderer/loadable_plugin_placeholder.cc

index e07b7fd3a03e8967b7ade6709784cc3bddf0eb83..339f58321de1cbabfc3b1f6fbfe51cdd10ece5d6 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.cc

+++ b/components/plugins/renderer/loadable_plugin_placeholder.cc

@@ -29,6 +29,9 @@

#include "third_party/WebKit/public/web/WebScriptSource.h"

#include "third_party/WebKit/public/web/WebSerializedScriptValue.h"

#include "third_party/WebKit/public/web/WebView.h"

+#include "url/gurl.h"

+#include "url/origin.h"

using base::UserMetricsAction;

using content::PluginInstanceThrottler;

using content::RenderThread;

@@ -45,7 +48,7 @@ void LoadablePluginPlaceholder::BlockForPowerSaverPoster() {

is_blocked_for_power_saver_poster_ = true;

render_frame()->RegisterPeripheralPlugin(

- GURL(GetPluginParams().url).GetOrigin(),

+ url::Origin(GURL(GetPluginParams().url)),

base::Bind(&LoadablePluginPlaceholder::MarkPluginEssential,

weak_factory_.GetWeakPtr(),

PluginInstanceThrottler::UNTHROTTLE_METHOD_BY_WHITELIST));