Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1341533007: mac: Fix a compile error when using libc++. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix a compile error when using libc++. Fixes a few errors that all look similar to: third_party/llvm-build/Release+Asserts/include/c++/v1/map:1365:17: error: no matching function for call to object of type const content_setting_bubble::compare_button' if (__tree_.value_comp().key_comp()(__k, __nd->__value_.__cc.first)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:573:16: note: in instantiation of member function 'std::__1::map<NSPopUpButton *, content_setting_bubble::MediaMenuParts *, content_setting_bubble::compare_button>>>::operator[]' requested here mediaMenus_[button] = menuParts; ^ chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h:43:8: note: candidate function not viable: 'this' argument has type 'const content_setting_bubble::compare_button', but method is not marked const bool operator()(NSPopUpButton *const a, NSPopUpButton *const b) { ^ No behavior change. BUG=400091 TBR=bauerb Committed: https://crrev.com/7c7f4e37d368d46f16010a513acb22ccce63e61f Cr-Commit-Position: refs/heads/master@{#348810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Nico
First to stamp wins!
5 years, 3 months ago (2015-09-15 00:28:42 UTC) #2
Jialiu Lin
lgtm On 2015/09/15 00:28:42, Nico wrote: > First to stamp wins!
5 years, 3 months ago (2015-09-15 00:55:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341533007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341533007/1
5 years, 3 months ago (2015-09-15 00:58:44 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-15 00:58:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341533007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341533007/1
5 years, 3 months ago (2015-09-15 01:00:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 01:35:23 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c7f4e37d368d46f16010a513acb22ccce63e61f Cr-Commit-Position: refs/heads/master@{#348810}
5 years, 3 months ago (2015-09-15 01:35:57 UTC) #11
Bernhard Bauer
LGTM On 2015/09/15 00:55:02, JialiuLin wrote: > lgtm > On 2015/09/15 00:28:42, Nico wrote: > ...
5 years, 3 months ago (2015-09-15 08:12:35 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:41:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c7f4e37d368d46f16010a513acb22ccce63e61f
Cr-Commit-Position: refs/heads/master@{#348810}

Powered by Google App Engine
This is Rietveld 408576698