Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1341533006: Remove use_name_for_id from ios_strings.grd to unblock translation process. (Closed)

Created:
5 years, 3 months ago by newt (away)
Modified:
5 years, 3 months ago
Reviewers:
sdefresne, blundell
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use_name_for_id from ios_strings.grd to unblock translation process. grd files that are sent off for translation cannot contain the use_name_for_id attribute as described in the bug. This removes use_name_for_id from ios_strings.grd to fix the extract strings step. This will need to be fixed for real as a follow-up, either by making IDS_IOS_ACCEPT_LANGUAGES and IDS_IOS_DEFAULT_ENCODING regular translatable strings, or by moving them into a separate file as is done with all the locale_settings_<platform>.grd files. BUG=531718 TBR=sdefresne@chromium.org Committed: https://crrev.com/0fbfa9f364c8e540f9c3c919aeaed3096ac4b013 Cr-Commit-Position: refs/heads/master@{#348764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341533006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341533006/1
5 years, 3 months ago (2015-09-14 22:43:07 UTC) #2
newt (away)
PTAL
5 years, 3 months ago (2015-09-14 22:43:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 22:59:32 UTC) #6
newt (away)
TBR'd sdefresne@chromium.org
5 years, 3 months ago (2015-09-14 23:19:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341533006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341533006/1
5 years, 3 months ago (2015-09-14 23:21:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 23:35:29 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0fbfa9f364c8e540f9c3c919aeaed3096ac4b013 Cr-Commit-Position: refs/heads/master@{#348764}
5 years, 3 months ago (2015-09-14 23:36:06 UTC) #11
sdefresne
On 2015/09/14 at 23:36:06, commit-bot wrote: > Patchset 1 (id:??) landed as https://crrev.com/0fbfa9f364c8e540f9c3c919aeaed3096ac4b013 > Cr-Commit-Position: ...
5 years, 3 months ago (2015-09-15 08:44:37 UTC) #12
newt (away)
On 2015/09/15 08:44:37, sdefresne wrote: > On 2015/09/14 at 23:36:06, commit-bot wrote: > > Patchset ...
5 years, 3 months ago (2015-09-15 16:53:17 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fbfa9f364c8e540f9c3c919aeaed3096ac4b013
Cr-Commit-Position: refs/heads/master@{#348764}

Powered by Google App Engine
This is Rietveld 408576698