Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: components/policy/core/common/schema_map.cc

Issue 134153005: Add strictness to Schema::Validate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@expand-policy-schema-2
Patch Set: pull from previous CL Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/schema_map.cc
diff --git a/components/policy/core/common/schema_map.cc b/components/policy/core/common/schema_map.cc
index 488af8d0f5168ee62cf973a4c00c11a6f89b9fd8..89d1daafe7fb6b69e4aa3aa1ef5b70b62c0399c1 100644
--- a/components/policy/core/common/schema_map.cc
+++ b/components/policy/core/common/schema_map.cc
@@ -63,7 +63,9 @@ void SchemaMap::FilterBundle(PolicyBundle* bundle) const {
const base::Value* policy_value = it_map->second.value;
Schema policy_schema = schema->GetProperty(policy_name);
++it_map;
- if (!policy_value || !policy_schema.Validate(*policy_value))
+ std::string error;
+ if (!policy_value || !policy_schema.Validate(*policy_value,
+ SCHEMA_VERY_STRICT, &error))
map->Erase(policy_name);
Joao da Silva 2014/01/22 10:49:53 You can log the error here, to assist extension de
binjin 2014/01/23 12:01:31 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698