Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: components/policy/core/common/schema_map.cc

Issue 134153005: Add strictness to Schema::Validate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@expand-policy-schema-2
Patch Set: fix a bug and enhance tests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/schema_map.cc
diff --git a/components/policy/core/common/schema_map.cc b/components/policy/core/common/schema_map.cc
index 488af8d0f5168ee62cf973a4c00c11a6f89b9fd8..56411fabd7e758538d247bb8c7c58e0443540e4f 100644
--- a/components/policy/core/common/schema_map.cc
+++ b/components/policy/core/common/schema_map.cc
@@ -4,6 +4,7 @@
#include "components/policy/core/common/schema_map.h"
+#include "base/logging.h"
#include "base/values.h"
#include "components/policy/core/common/policy_bundle.h"
#include "components/policy/core/common/policy_map.h"
@@ -63,8 +64,13 @@ void SchemaMap::FilterBundle(PolicyBundle* bundle) const {
const base::Value* policy_value = it_map->second.value;
Schema policy_schema = schema->GetProperty(policy_name);
++it_map;
- if (!policy_value || !policy_schema.Validate(*policy_value))
+ std::string error;
+ if (!policy_value || !policy_schema.Validate(*policy_value,
+ SCHEMA_STRICT, &error)) {
Joao da Silva 2014/01/23 15:52:36 Try formatting this line with clang-format:
binjin 2014/01/23 17:20:13 Done.
+ LOG(ERROR) << "Dropping policy " << policy_name << " for " <<
+ it->first.component_id << " because it's not valid: " << error;
Joao da Silva 2014/01/23 15:52:36 Run clang-format on this one too; I didn't format
binjin 2014/01/23 17:20:13 Done.
map->Erase(policy_name);
+ }
}
}
}

Powered by Google App Engine
This is Rietveld 408576698