Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134153002: Use VTTScanner for VTT cue settings parsing (Closed)

Created:
6 years, 11 months ago by fs
Modified:
6 years, 11 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use VTTScanner for VTT cue settings parsing Transcribe VTTCue::parseSettings (and helpers) into using VTTScanner to perform the parsing of cue settings. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164955

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -88 lines) Patch
M LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 10 chunks +56 lines, -81 lines 2 comments Download
M Source/core/html/track/vtt/VTTScanner.h View 3 chunks +29 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTScanner.cpp View 1 chunk +41 lines, -5 lines 0 comments Download
M Source/core/html/track/vtt/VTTScannerTest.cpp View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 11 months ago (2014-01-10 17:08:53 UTC) #1
Mike West
LGTM with one question. https://codereview.chromium.org/134153002/diff/1/Source/core/html/track/vtt/VTTCue.cpp File Source/core/html/track/vtt/VTTCue.cpp (right): https://codereview.chromium.org/134153002/diff/1/Source/core/html/track/vtt/VTTCue.cpp#newcode964 Source/core/html/track/vtt/VTTCue.cpp:964: linePosition = -linePosition; Where does ...
6 years, 11 months ago (2014-01-13 07:24:20 UTC) #2
fs
https://codereview.chromium.org/134153002/diff/1/Source/core/html/track/vtt/VTTCue.cpp File Source/core/html/track/vtt/VTTCue.cpp (right): https://codereview.chromium.org/134153002/diff/1/Source/core/html/track/vtt/VTTCue.cpp#newcode964 Source/core/html/track/vtt/VTTCue.cpp:964: linePosition = -linePosition; On 2014/01/13 07:24:20, Mike West wrote: ...
6 years, 11 months ago (2014-01-13 08:12:00 UTC) #3
Mike West
On 2014/01/13 08:12:00, fs wrote: > https://codereview.chromium.org/134153002/diff/1/Source/core/html/track/vtt/VTTCue.cpp > File Source/core/html/track/vtt/VTTCue.cpp (right): > > https://codereview.chromium.org/134153002/diff/1/Source/core/html/track/vtt/VTTCue.cpp#newcode964 > ...
6 years, 11 months ago (2014-01-13 09:18:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/134153002/1
6 years, 11 months ago (2014-01-13 09:30:32 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 09:38:31 UTC) #6
Message was sent while issue was closed. 
Change committed as 164955

Powered by Google App Engine
This is Rietveld 408576698