chrome/browser/resources/settings/on_startup_page/startup_urls_page.js - Issue 1341463002: Add on_startup_page/compiled_resources.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Issue 1341463002: Add on_startup_page/compiled_resources.gyp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: currentRoute -> Object Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/compiled_resources.gyp ('k') | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

index 9bce9e97b960c5ab00f652ffabac3385e336fb0d..c194a7d83c3257e9efeb7c9a42203ea3be603b5f 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

@@ -56,10 +56,13 @@ Polymer({

if (!value)

return;

this.push('prefs.session.startup_urls.value', value);

- this.newUrl = undefined;

+ this.newUrl = '';

- /** @private */

+ /**

+ * @param {!{model: !{index: number}}} e

+ * @private

+ */

onRemoveUrlTap_: function(e) {

this.splice('prefs.session.startup_urls.value', e.model.index, 1);