Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/IceLoopAnalyzer.h

Issue 1341423002: Reflow comments to use the full width. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix spelling and rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceLiveness.cpp ('k') | src/IceLoopAnalyzer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceLoopAnalyzer.h
diff --git a/src/IceLoopAnalyzer.h b/src/IceLoopAnalyzer.h
index 59917981c974b6196b6f04090310db4bebbc3107..19d38d1ccc32369981ea03cbc319058eaeeb1ea8 100644
--- a/src/IceLoopAnalyzer.h
+++ b/src/IceLoopAnalyzer.h
@@ -35,6 +35,10 @@ public:
///
/// This only computes the loop nest depth within the function and does not
/// take into account whether the function was called from within a loop.
+ // TODO(ascull): this currently uses a extension of Tarjan's algorithm with
+ // is bounded linear. ncbray suggests another algorithm which is linear in
+ // practice but not bounded linear. I think it also finds dominators.
+ // http://lenx.100871.net/papers/loop-SAS.pdf
void computeLoopNestDepth();
private:
@@ -88,11 +92,11 @@ private:
using LoopNodePtrList =
std::vector<LoopNode *, CfgLocalAllocator<LoopNode *>>;
- /// Process the node as part as part of Tarjan's algorithm and return either
- /// a node to recurse into or nullptr when the node has been fully processed.
+ /// Process the node as part as part of Tarjan's algorithm and return either a
+ /// node to recurse into or nullptr when the node has been fully processed.
LoopNode *processNode(LoopNode &Node);
- /// The fuction to analyze for loops.
+ /// The function to analyze for loops.
Cfg *const Func;
/// A list of decorated nodes in the same order as Func->getNodes() which
/// means the node's index will also be valid in this list.
« no previous file with comments | « src/IceLiveness.cpp ('k') | src/IceLoopAnalyzer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698