Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2353)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 13414007: Report disabled plugin in CreatePlugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/plugins/plugin_placeholder.cc » ('j') | chrome/renderer/plugins/plugin_uma_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 5e5cde70c3870c673974223c64f9d979c43e7ec5..6d50a8ff7dbe6af25b6dd0661fdc6aadfabcab89 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -520,8 +520,7 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
return PluginPlaceholder::CreateMobileYoutubePlugin(render_view, frame,
original_params)->plugin();
#endif
- MissingPluginReporter::GetInstance()->ReportPluginMissing(
- orig_mime_type, url);
+ PluginUMAReporter::GetInstance()->ReportPluginMissing(orig_mime_type, url);
placeholder = PluginPlaceholder::CreateMissingPlugin(
render_view, frame, original_params);
} else {
@@ -645,6 +644,8 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
break;
}
case ChromeViewHostMsg_GetPluginInfo_Status::kDisabled: {
+ PluginUMAReporter::GetInstance()->ReportPluginDisabled(orig_mime_type,
+ url);
placeholder = PluginPlaceholder::CreateBlockedPlugin(
render_view, frame, params, plugin, identifier, group_name,
IDR_DISABLED_PLUGIN_HTML,
« no previous file with comments | « no previous file | chrome/renderer/plugins/plugin_placeholder.cc » ('j') | chrome/renderer/plugins/plugin_uma_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698