Report disabled plugin in CreatePlugin.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 493 matching lines @@
     const ChromeViewHostMsg_GetPluginInfo_Output& output) {
   const ChromeViewHostMsg_GetPluginInfo_Status& status = output.status;
   const WebPluginInfo& plugin = output.plugin;
   const std::string& actual_mime_type = output.actual_mime_type;
   const string16& group_name = output.group_name;
   const std::string& identifier = output.group_identifier;
   ChromeViewHostMsg_GetPluginInfo_Status::Value status_value = status.value;
   GURL url(original_params.url);
   std::string orig_mime_type = original_params.mimeType.utf8();
   PluginPlaceholder* placeholder = NULL;
 

[ddorwin, 2013/04/04 19:09:50]

We could do a histogram of values based on this |status_value|. That would cover
everything. This would be the inverse (list of status for each type) of what we
currently have (type by status).
Also, ReportPluginMissing() is used in another place, and I'm not sure what the
implication of such a change would be.

[Bernhard Bauer, 2013/04/04 21:14:31]

The other place should be fine. What happens is that in theory, a plug-in could
go missing between the time we create a click-to-play placeholder for it and the
time the user clicks on it, so we deal with that, and also record the plug-in as
missing in that case.

[xhwang, 2013/04/04 23:10:33]

That's a good suggestion. But probably belongs to another CL.

   // If the browser plugin is to be enabled, this should be handled by the
   // renderer, so the code won't reach here due to the early exit in
   // OverrideCreatePlugin.
   if (status_value == ChromeViewHostMsg_GetPluginInfo_Status::kNotFound ||
       orig_mime_type == content::kBrowserPluginMimeType) {

[ddorwin, 2013/04/04 19:09:50]

I wonder if kBrowserPluginMimeType is polluting stats since it is unhandled
falls into the OTHER category. Maybe we should handle kBrowserPluginMimeType
explicitly in plugin_uma.cc.

[xhwang, 2013/04/04 23:10:33]

sg, but that'll belong to another CL.

 #if defined(ENABLE_MOBILE_YOUTUBE_PLUGIN)
     if (PluginPlaceholder::IsYouTubeURL(url, orig_mime_type))
       return PluginPlaceholder::CreateMobileYoutubePlugin(render_view, frame,
           original_params)->plugin();
 #endif
-    MissingPluginReporter::GetInstance()->ReportPluginMissing(
-        orig_mime_type, url);
+    PluginUMAReporter::GetInstance()->ReportPluginMissing(orig_mime_type, url);
     placeholder = PluginPlaceholder::CreateMissingPlugin(
         render_view, frame, original_params);
   } else {
     // TODO(bauerb): This should be in content/.
     WebPluginParams params(original_params);
     for (size_t i = 0; i < plugin.mime_types.size(); ++i) {
       if (plugin.mime_types[i].mime_type == actual_mime_type) {
         AppendParams(plugin.mime_types[i].additional_param_names,
                      plugin.mime_types[i].additional_param_values,
                      &params.attributeNames,
@@ skipping 103 matching lines @@
         RenderThread::Get()->RecordUserMetrics("Plugin_NPAPINotSupported");
         placeholder = PluginPlaceholder::CreateBlockedPlugin(
             render_view, frame, params, plugin, identifier, group_name,
             IDR_BLOCKED_PLUGIN_HTML,
             l10n_util::GetStringUTF16(IDS_PLUGIN_NOT_SUPPORTED_METRO));
         render_view->Send(new ChromeViewHostMsg_NPAPINotSupported(
             render_view->GetRoutingID(), identifier));
         break;
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kDisabled: {
+        PluginUMAReporter::GetInstance()->ReportPluginDisabled(orig_mime_type,
+                                                               url);
         placeholder = PluginPlaceholder::CreateBlockedPlugin(
             render_view, frame, params, plugin, identifier, group_name,
             IDR_DISABLED_PLUGIN_HTML,
             l10n_util::GetStringFUTF16(IDS_PLUGIN_DISABLED, group_name));
         break;
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kOutdatedBlocked: {
 #if defined(ENABLE_PLUGIN_INSTALLATION)
         placeholder = PluginPlaceholder::CreateBlockedPlugin(
             render_view, frame, params, plugin, identifier, group_name,
@@ skipping 567 matching lines @@
       return true;
   }
 
   if (request_os_file_handle_allowed_hosts_.count(inner.host()))
     return true;
 
   return false;
 }
 
 }  // namespace chrome