Use GN subconfigs for Android, optimization, and symbols.

Use GN subconfigs for Android, optimization, and symbols.

This new GN features allows configs to reference other configs, which allows
separating out some of the harrier bits of code. This patch separates out a few
things as a first use of this feature.

Committed: https://crrev.com/9ba0104655768a5f7102fae762dbab59af48fef7
Cr-Commit-Position: refs/heads/master@{#351003}

[brettw, 2015-09-15 20:14:08]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-09-15 20:14:08]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-09-15 20:14:08]

Blocked on a GN roll containing https://codereview.chromium.org/1342183003/

I plan to split out other platform's stuff in follow-ups.

[brettw, 2015-09-15 20:14:08]

Blocked on a GN roll containing https://codereview.chromium.org/1342183003/

I plan to split out other platform's stuff in follow-ups.

[Dirk Pranke, 2015-09-15 21:12:49]

lgtm.

Roland, you may find this CL (and the new feature in GN being added in
https://codereview.chromium.org/1342183003/ ) useful as a way of structuring
NaCl-specific things.

[Dirk Pranke, 2015-09-15 21:19:24]

Oh, actually, I'm not okay with the description of this change.

"nested configs" seems like the wrong way to describe this. Maybe "dependent
configs" instead? See comments on other CL.

[brettw, 2015-09-16 19:27:23]

Updated terminology to match the other patch

[Dirk Pranke, 2015-09-16 21:07:31]

lgtm

https://codereview.chromium.org/1341373002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1341373002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:1311: config("symbols") {
nit: I wonder if this would be better named as "full_symbols" ?

[brettw, 2015-09-16 21:34:32]

https://codereview.chromium.org/1341373002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1341373002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:1311: config("symbols") {
On 2015/09/16 21:07:31, Dirk Pranke wrote:
> nit: I wonder if this would be better named as "full_symbols" ?

I'm not opposed to renaming it but it's in like 5 repos and it seems like more
effort than it's worth.

[Dirk Pranke, 2015-09-16 22:19:53]

On 2015/09/16 21:34:32, brettw wrote:
>
https://codereview.chromium.org/1341373002/diff/20001/build/config/compiler/B...
> File build/config/compiler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1341373002/diff/20001/build/config/compiler/B...
> build/config/compiler/BUILD.gn:1311: config("symbols") {
> On 2015/09/16 21:07:31, Dirk Pranke wrote:
> > nit: I wonder if this would be better named as "full_symbols" ?
> 
> I'm not opposed to renaming it but it's in like 5 repos and it seems like more
> effort than it's worth.

ok

[brettw, 2015-09-26 05:17:33]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-26 05:17:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341373002/20001

[commit-bot: I haz the power, 2015-09-26 05:52:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-26 05:52:34]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-09-26 20:38:09]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-09-26 20:38:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341373002/20001

[commit-bot: I haz the power, 2015-09-26 20:42:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-26 20:43:19]

Patchset 2 (id:??) landed as
https://crrev.com/9ba0104655768a5f7102fae762dbab59af48fef7
Cr-Commit-Position: refs/heads/master@{#351003}