Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 134133004: Revert of Retry "Replace RenderFullScreen with top layer" (Closed)

Created:
6 years, 10 months ago by falken
Modified:
6 years, 10 months ago
Reviewers:
esprehn, Rick Byers
CC:
blink-reviews, zoltan1, dsinclair, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Inactive
Visibility:
Public.

Description

Revert of Retry "Replace RenderFullScreen with top layer" (https://codereview.chromium.org/142653003/) Reason for revert: Flaky crashes on full-screen-element-stack.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/26189 This test also crashed after the last attempt, but it looked like it was not due to this patch since it kept crashing well after that patch was reverted. It looks real now though. Original issue's description: > Retry "Replace RenderFullScreen with top layer" > > This patch makes the Fullscreen API use the top layer, as per the latest > Fullscreen spec. This retry fixes some tests/expectations. > > Previously landed as r165904 and r165710 > Codereviews: > https://codereview.chromium.org/134753003/ > https://codereview.chromium.org/139743005/ > > BUG=240576, 246077 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166114 TBR=rbyers@chromium.org,esprehn@chromium.org NOTREECHECKS=true NOTRY=true BUG=240576, 246077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -287 lines) Patch
M LayoutTests/TestExpectations View 4 chunks +5 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html View 1 chunk +0 lines, -105 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fullscreen/anonymous-block-merge-crash.html View 1 chunk +3 lines, -9 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-is-in-top-layer.html View 1 chunk +0 lines, -40 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder.html View 1 chunk +73 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-video-has-backdrop.html View 1 chunk +0 lines, -31 lines 0 comments Download
A LayoutTests/platform/linux/fullscreen/parent-flow-inline-with-block-child-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/fullscreen.css View 1 chunk +1 line, -22 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 10 chunks +50 lines, -14 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDialogElement.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 3 chunks +1 line, -16 lines 0 comments Download
A Source/core/rendering/RenderFullScreen.h View 1 chunk +60 lines, -0 lines 0 comments Download
A Source/core/rendering/RenderFullScreen.cpp View 1 chunk +189 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Created Revert of Retry "Replace RenderFullScreen with top layer"
6 years, 10 months ago (2014-01-30 11:03:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/134133004/1
6 years, 10 months ago (2014-01-30 11:03:49 UTC) #2
commit-bot: I haz the power
Change committed as 166118
6 years, 10 months ago (2014-01-30 11:04:45 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 11:05:18 UTC) #4
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698