Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3439)

Unified Diff: base/test/test_suite.cc

Issue 134133002: Avoid printing three stack traces on CHECK failure. Print just one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_suite.cc
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc
index 5154c0578587a7661b3d383a7ffabfaf38b47d31..40d81a6841ac5903e28e03881ad959fbe1918fca 100644
--- a/base/test/test_suite.cc
+++ b/base/test/test_suite.cc
@@ -239,7 +239,10 @@ void TestSuite::UnitTestAssertHandler(const std::string& str) {
fflush(stderr);
}
#endif // defined(OS_ANDROID)
- RAW_LOG(FATAL, str.c_str());
+
+ // The logging system actually prints the message before calling the assert
+ // handler. Just exit now to avoid printing too many stack traces.
+ _exit(1);
}
void TestSuite::SuppressErrorDialogs() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698