Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 134133002: Avoid printing three stack traces on CHECK failure. Print just one. (Closed)

Created:
6 years, 11 months ago by Paweł Hajdan Jr.
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, Ryan Hamilton
Visibility:
Public.

Description

Avoid printing three stack traces on CHECK failure. Print just one. BUG=332468 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M base/test/test_suite.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Please review: Brett: the CL Ryan: FYI
6 years, 11 months ago (2014-01-10 15:55:01 UTC) #1
brettw
lgtm
6 years, 11 months ago (2014-01-10 18:22:13 UTC) #2
Paweł Hajdan Jr.
6 years, 11 months ago (2014-01-13 20:00:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r244564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698