Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1341293002: [heap] Extend mutex guards for CodeRange. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Extend mutex guards for CodeRange. Previously the mutex only guarded free_list_. The extension covers also allocation_list_. BUG=chromium:524425 LOG=N Committed: https://crrev.com/2c17f1580b0b62d01dc2f874dfff7041fc403990 Cr-Commit-Position: refs/heads/master@{#30748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M src/heap/spaces.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 4 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341293002/1
5 years, 3 months ago (2015-09-15 12:21:29 UTC) #2
Michael Lippautz
This is another spinoff from the prototype. Basically CodeRange::ReserveBlock is potentially called concurrently. This means ...
5 years, 3 months ago (2015-09-15 12:46:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 13:21:40 UTC) #6
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-15 13:41:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341293002/1
5 years, 3 months ago (2015-09-15 13:44:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 13:45:23 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 13:45:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c17f1580b0b62d01dc2f874dfff7041fc403990
Cr-Commit-Position: refs/heads/master@{#30748}

Powered by Google App Engine
This is Rietveld 408576698