Add FetchUtils::normalizeHeaderValue( )

Add FetchUtils::normalizeHeaderValue()
These api will be used to normalize the header values
in Fetch and XHR module.

Background information:
This is splitted from [1], and will be used by [1] and [2].
[1] https://codereview.chromium.org/1288263003/
[2] https://codereview.chromium.org/1342443004/

BUG=455099

[shiva.jm, 2015-09-15 10:45:53]

shiva.jm@samsung.com changed reviewers:
+ hiroshige@chromium.org, japhet@chromium.org, mkwst@chromium.org,
tyoshino@chromium.org, yhirano@chromium.org

[shiva.jm, 2015-09-15 10:46:16]

pls have a look.

[hiroshige, 2015-09-15 10:51:11]

Thanks! LGTM.

> CL Description
> Add normalizeHeaderValue() util api
How about "Add FetchUtils::normalizeHeaderValue()"?

Background information for record and other reviewers:
This is splitted from [1], and will be used by [1] and [2].
[1] https://codereview.chromium.org/1288263003/
[2] https://codereview.chromium.org/1342443004/

core/fetch OWNERs, could you take a look?

[tyoshino (SeeGerritForStatus), 2015-09-15 13:41:26]

lgtm

[shiva.jm, 2015-09-15 14:27:21]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-15 14:27:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/1

[commit-bot: I haz the power, 2015-09-15 15:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 15:46:24]

Dry run: This issue passed the CQ dry run.

[yhirano, 2015-09-16 05:54:00]

lgtm

[shiva.jm, 2015-09-16 05:54:53]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-09-16 05:55:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/1

[hiroshige, 2015-09-16 07:58:39]

japhet@, could you take a look as a core/fetch OWNER?

[commit-bot: I haz the power, 2015-09-16 08:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 08:26:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)

[Mike West, 2015-09-16 12:39:43]

LGTM, but please add a unit test verifying the method's behavior.

[shiva.jm, 2015-09-19 04:45:08]

On 2015/09/16 12:39:43, Mike West (slow) wrote:
> LGTM, but please add a unit test verifying the method's behavior.

FetchUtils.cpp has no unit test file under core/fetch/. so shall we add
new test file FetchUtilsTest.cpp under core/fetch/, OR shall we add the test for
new api added in ResourceTest.cpp itself ?.

[Mike West, 2015-09-19 09:45:06]

On 2015/09/19 at 04:45:08, shiva.jm wrote:
> On 2015/09/16 12:39:43, Mike West (slow) wrote:
> > LGTM, but please add a unit test verifying the method's behavior.
> 
> FetchUtils.cpp has no unit test file under core/fetch/. so shall we add
> new test file FetchUtilsTest.cpp under core/fetch/, OR shall we add the test
for new api added in ResourceTest.cpp itself ?.

Probably best to add a FetchUtilsTest.cpp.

[shiva.jm, 2015-09-21 07:13:41]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 07:13:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/80001

[commit-bot: I haz the power, 2015-09-21 07:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 07:23:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shiva.jm, 2015-09-21 10:09:32]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 10:09:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/100001

[commit-bot: I haz the power, 2015-09-21 10:35:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 10:35:47]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[shiva.jm, 2015-09-21 11:12:17]

updated the patch with tests, pls have a look.

[Mike West, 2015-09-21 11:31:27]

LGTM % test nits.

https://codereview.chromium.org/1341273002/diff/100001/Source/core/fetch/Fetc...
File Source/core/fetch/FetchUtilsTest.cpp (right):

https://codereview.chromium.org/1341273002/diff/100001/Source/core/fetch/Fetc...
Source/core/fetch/FetchUtilsTest.cpp:28: EXPECT_EQ("test",
FetchUtils::normalizeHeaderValue("test"));
Nit: Can you add leading examples of these values as well. Right now you're only
testing them at the end of the string.

Nit: Can you add whitespace inside the test value to ensure that it's not
stripped?

https://codereview.chromium.org/1341273002/diff/100001/Source/core/fetch/Fetc...
Source/core/fetch/FetchUtilsTest.cpp:28: EXPECT_EQ("test",
FetchUtils::normalizeHeaderValue("test"));
Nit: Can you add leading examples of these values as well. Right now you're only
testing them at the end of the string.

Nit: Can you add whitespace inside the test value to ensure that it's not
stripped?

[shiva.jm, 2015-09-22 04:25:57]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 04:26:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/110001

[shiva.jm, 2015-09-22 05:35:12]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 05:35:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/130001

[shiva.jm, 2015-09-22 06:01:09]

updated the tests, pls have a look.

https://codereview.chromium.org/1341273002/diff/100001/Source/core/fetch/Fetc...
File Source/core/fetch/FetchUtilsTest.cpp (right):

https://codereview.chromium.org/1341273002/diff/100001/Source/core/fetch/Fetc...
Source/core/fetch/FetchUtilsTest.cpp:28: EXPECT_EQ("test",
FetchUtils::normalizeHeaderValue("test"));
On 2015/09/21 11:31:27, Mike West (slow) wrote:
> Nit: Can you add leading examples of these values as well. Right now you're
only
> testing them at the end of the string.
> 
> Nit: Can you add whitespace inside the test value to ensure that it's not
> stripped?

Done.

https://codereview.chromium.org/1341273002/diff/100001/Source/core/fetch/Fetc...
Source/core/fetch/FetchUtilsTest.cpp:28: EXPECT_EQ("test",
FetchUtils::normalizeHeaderValue("test"));
On 2015/09/21 11:31:27, Mike West (slow) wrote:
> Nit: Can you add leading examples of these values as well. Right now you're
only
> testing them at the end of the string.
> 
> Nit: Can you add whitespace inside the test value to ensure that it's not
> stripped?

Done.

[commit-bot: I haz the power, 2015-09-22 07:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 07:21:43]

Dry run: This issue passed the CQ dry run.

[shiva.jm, 2015-09-22 11:08:11]

On 2015/09/22 07:21:43, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

bots have passed all tests, shall we commit ?

[shiva.jm, 2015-09-22 15:21:22]

bots have passed all tests, shall we commit ?

[shiva.jm, 2015-09-23 03:25:58]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 03:26:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/130001

[commit-bot: I haz the power, 2015-09-23 03:40:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 03:40:47]

Dry run: This issue passed the CQ dry run.

[shiva.jm, 2015-09-23 15:26:21]

The CQ bit was checked by shiva.jm@samsung.com

[shiva.jm, 2015-09-23 15:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, tyoshino@chromium.org, yhirano@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1341273002/#ps130001
(title: " ")

[commit-bot: I haz the power, 2015-09-23 15:26:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/130001

[commit-bot: I haz the power, 2015-09-23 15:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 15:32:22]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shiva.jm, 2015-09-24 01:04:51]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-09-24 01:05:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/130001

[commit-bot: I haz the power, 2015-09-24 01:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 01:08:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shiva.jm, 2015-09-24 05:18:24]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-09-24 05:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341273002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341273002/130001

[commit-bot: I haz the power, 2015-09-24 05:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 05:19:22]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rwlbuis, 2016-02-25 22:01:08]

This landed as crbug.com/1364993003, closing.