Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1341233002: X87: [stubs] Simplify the non-function case of CallConstructStub. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Simplify the non-function case of CallConstructStub. port 622fa0ea21b3517b1feaed447c87e580bafac865 (r30691). original commit message: Currently we do this dance between the CallConstructStub, the CALL_* builtins and the %GetConstructorDelegate, %GetProxyTrap, and %Apply runtime functions for every [[Construct]] operation on non-function callables. This is complexity is unnecessary, and can be simplified to work without any JS builtin. This will also make it a lot easier to implement ES6 compliant [[Construct]] for proxies. Also sanitize the invariant for CallConstructStub, which up until now always restored the context itself, but that force us to always create another copy of all arguments in case of proxies and other callables, so we can relax that constraint by making the caller restore the context (this only affects fullcodegen, since the optimizing compilers already properly restore the context anyway). BUG= Committed: https://crrev.com/ec2f11c577c6e804a822f5af7a1e2e9837340068 Cr-Commit-Position: refs/heads/master@{#30740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +24 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-15 10:14:48 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-15 10:20:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341233002/1
5 years, 3 months ago (2015-09-15 10:20:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 11:26:57 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 11:27:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec2f11c577c6e804a822f5af7a1e2e9837340068
Cr-Commit-Position: refs/heads/master@{#30740}

Powered by Google App Engine
This is Rietveld 408576698