Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 134123003: Generate proper LatencyInfo components for synthetic gestures (Closed)

Created:
6 years, 11 months ago by jdduke (slow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Generate proper LatencyInfo components for synthetic gestures Replace content::InputEvent usage with blink::WebInputEvent usage in synthetic gesture dispatch. This affords the SyntheticGestureTarget a chance to generate the necessary ui::LatencyInfo components prior to event dispatch, simplifying the hooks necessary for telemetry and easing the burden on the gesture dispatch caller. BUG=246034 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244254

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Remove InputEvent forward decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -112 lines) Patch
M content/browser/renderer_host/input/synthetic_gesture.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 1 8 chunks +64 lines, -63 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target.h View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_aura.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_base.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_pinch_gesture.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_tap_gesture.cc View 5 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jdduke (slow)
What do you think?
6 years, 11 months ago (2014-01-10 17:26:51 UTC) #1
Yufeng Shen (Slow to review)
On 2014/01/10 17:26:51, jdduke wrote: > What do you think? LGTM in terms of LatencyInfo ...
6 years, 11 months ago (2014-01-10 18:01:41 UTC) #2
Dominik Grewe
LGTM, thanks!
6 years, 11 months ago (2014-01-10 18:45:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/134123003/90001
6 years, 11 months ago (2014-01-10 18:54:56 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 22:01:20 UTC) #5
Message was sent while issue was closed.
Change committed as 244254

Powered by Google App Engine
This is Rietveld 408576698