Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1341223002: X87: Vector ICs: The Oracle needs to report feedback for the object literals and the count operatio… (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Vector ICs: The Oracle needs to report feedback for the object literals and the count operation. port 752b0308df72461bfeb644bf6dd8dd331fcdb722 (r30686). original commit message: The refactoring is because it's awkward and error-prone to deterimine which IC slot an ObjectLiteralProperty uses for feedback. The fix is for each one to know it's own slot. In the numbering pass, we allocate slots for the ObjectLiteral, then hand out those slots into the properties. It adds one word to the ObjectLiteralProperty expression - I'm investigating if thats a problem. This changes makes compiling the object literal cleaner across the three compilers. Also, the slot allocation logic in ObjectLiteral::ComputeFeedbackRequirements() was refactoring to mimic the style in full-codegen. This is useful since it must remain in sync with FullCodegen::VisitObjectLiteral(). BUG= Committed: https://crrev.com/1b8610088cf46fb031638005c7933cdef71cf1f7 Cr-Commit-Position: refs/heads/master@{#30739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -48 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 12 chunks +45 lines, -48 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-15 10:14:22 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-15 10:19:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341223002/1
5 years, 3 months ago (2015-09-15 10:20:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 11:20:39 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 11:20:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b8610088cf46fb031638005c7933cdef71cf1f7
Cr-Commit-Position: refs/heads/master@{#30739}

Powered by Google App Engine
This is Rietveld 408576698